Skip to content

Conversation

@jamhpark
Copy link
Member

@jamhpark jamhpark commented Jul 4, 2025

Fixes #8002

What changes did you make?

  • Removed name, github-handle, role, links, and picture from the Expunge Assist leadership team (_projects/expunge-assist.md)

Why did you make the changes (we will use this info to test)?

  • To keep the Expunge Assist leadership team up-to-date

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied

Screenshot before

Visuals after changes are applied

Screenshot after

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Jul 6, 2025
@caz002 caz002 self-requested a review July 7, 2025 04:47
@caz002
Copy link
Member

caz002 commented Jul 7, 2025

Review ETA: 7/7/25
Availability: after 2pm most days

Copy link
Member

@caz002 caz002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this pull request @jamhpark !

Things done well

  • Pull request description accurately describes changes
  • Only the requested file in the issue was modified
  • Images clearly show changes
  • Code passes CodeQL quality checks

Changes to make

  • Minor change: remove the extra whitespace added at the end of the codeblock for Maria Weissman, as the line is showing up as edited in the "Files changed" view
Screenshot 2025-07-07 at 10 18 35 AM

After the change is made, I can approve your pull request. Thank you for your help on the issue!

@github-project-automation github-project-automation bot moved this from PR Needs review to PRs being reviewed in P: HfLA Website: Project Board Jul 7, 2025
@valdezg valdezg assigned valdezg and unassigned valdezg Jul 8, 2025
@jamhpark
Copy link
Member Author

@caz002 Thank you for reviewing my pull request. I've been trying to edit the file on my computer, but running into some issues with using git. I'll review how to use the git commands first, then try making changes to the file. Thank you!

@caz002
Copy link
Member

caz002 commented Jul 11, 2025

@jamhpark Ok no worries! Let me know if you need any help with using git or editing the branch.

@TheManTheMythTheGameDev
Copy link
Member

Review ETA: EOD 7/18/25
Availability: Weekends after 12

@jamhpark
Copy link
Member Author

@caz002 @TheManTheMythTheGameDev Hi everyone, I've been trying to resolve the git-related issues I encountered, but I've realized that my current understanding of git commands and file synchronization isn't quite where it needs to be to effectively move forward. At this point, I think it would be best for me to unassign myself from this issue and let another developer take it on. Thank you for your understanding!

Progress: 1st Pull Request submitted, but the extra whitespace needs to be removed before merging

@ryanfkeller
Copy link
Member

Hi @jamhpark,

Thanks for taking the time to contribute, and sorry for the git trouble you're having! Git definitely has a learning curve, but becomes a lot easier with familiarity and practice. Since you're already partway through this task, I'd encourage you to stick with it as a learning opportunity. These Good First Issues are perfect for exactly this purpose.

For your specific git issue, I'd recommend posting in the #hfla-site Slack channel with details about what error message you're seeing, what commands you tried to run, and what you were expecting to happen. The dev team there is very helpful and can give you targeted guidance.

If you want to brush up on git basics while you're working through this, the official Git tutorial or interactive Git tutorial might be useful.

Git skills will definitely serve you well for future HfLA contributions and software work!

@t-will-gillis
Copy link
Member

Dev unassigned from original issue, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe

Projects

Development

Successfully merging this pull request may close these issues.

Update Project Profile: Expunge Assist- Remove Srishti Gupta

6 participants