-
-
Notifications
You must be signed in to change notification settings - Fork 843
Removed Srishti Gupta's profile from Expunge Assist Project Team #8242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Review ETA: 7/7/25 |
caz002
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this pull request @jamhpark !
Things done well
- Pull request description accurately describes changes
- Only the requested file in the issue was modified
- Images clearly show changes
- Code passes CodeQL quality checks
Changes to make
- Minor change: remove the extra whitespace added at the end of the codeblock for Maria Weissman, as the line is showing up as edited in the "Files changed" view
After the change is made, I can approve your pull request. Thank you for your help on the issue!
|
@caz002 Thank you for reviewing my pull request. I've been trying to edit the file on my computer, but running into some issues with using git. I'll review how to use the git commands first, then try making changes to the file. Thank you! |
|
@jamhpark Ok no worries! Let me know if you need any help with using git or editing the branch. |
|
Review ETA: EOD 7/18/25 |
|
@caz002 @TheManTheMythTheGameDev Hi everyone, I've been trying to resolve the git-related issues I encountered, but I've realized that my current understanding of git commands and file synchronization isn't quite where it needs to be to effectively move forward. At this point, I think it would be best for me to unassign myself from this issue and let another developer take it on. Thank you for your understanding! Progress: 1st Pull Request submitted, but the extra whitespace needs to be removed before merging |
|
Hi @jamhpark, Thanks for taking the time to contribute, and sorry for the git trouble you're having! Git definitely has a learning curve, but becomes a lot easier with familiarity and practice. Since you're already partway through this task, I'd encourage you to stick with it as a learning opportunity. These Good First Issues are perfect for exactly this purpose. For your specific git issue, I'd recommend posting in the #hfla-site Slack channel with details about what error message you're seeing, what commands you tried to run, and what you were expecting to happen. The dev team there is very helpful and can give you targeted guidance. If you want to brush up on git basics while you're working through this, the official Git tutorial or interactive Git tutorial might be useful. Git skills will definitely serve you well for future HfLA contributions and software work! |
|
Dev unassigned from original issue, closing |
Fixes #8002
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied