Skip to content

Add Audreen Fune to 311 Data Page#8243

Merged
t-will-gillis merged 2 commits intohackforla:gh-pagesfrom
nubilaxl:add-audreen-fune-8014
Aug 17, 2025
Merged

Add Audreen Fune to 311 Data Page#8243
t-will-gillis merged 2 commits intohackforla:gh-pagesfrom
nubilaxl:add-audreen-fune-8014

Conversation

@nubilaxl
Copy link
Contributor

@nubilaxl nubilaxl commented Jul 4, 2025

Fixes #8014

What changes did you make?

  • Added Audreen Fune to 311 Data project page

Why did you make the changes (we will use this info to test)?

  • To keep project information up to date

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied

Screenshot 2025-07-04 at 10 15 02 AM

Visuals after changes are applied

Screenshot 2025-07-04 at 10 25 50 AM

@github-actions
Copy link

github-actions bot commented Jul 4, 2025

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b nubilaxl-add-audreen-fune-8014 gh-pages
git pull https://github.com/nubilaxl/website.git add-audreen-fune-8014

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Jul 4, 2025
@valdezg valdezg assigned valdezg and unassigned valdezg Jul 8, 2025
@santi-jose santi-jose self-requested a review July 9, 2025 01:49
@santi-jose
Copy link
Member

santi-jose commented Jul 9, 2025

Review ETA: 6 PM 7/14/2025
Availability: 5-8 PM Monday-Friday

@t-will-gillis t-will-gillis self-requested a review July 13, 2025 17:56
Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nubilaxl Congratulations on submitting your first PR! Looks great:

  • the 'from' and 'to' branches are correct
  • the original issue is linked
  • there are before and after screenshots attached
  • the code changes appear to be correct

Here are some comments:

  • For "What changes did you make?", you can answer this more concisely by saying "Added Audreen Fune to 311 Data project page" or something similar
  • The "Why did you make the changes..." response is good
  • Please check the appropriate box for the "CodeQL Alerts" section, that is "I have checked this PR for CodeQL alerts and none were found"
  • Finally, if you scroll to the bottom of this PR you will see that your branch has a merge conflict that needs to be resolved. Merge conflicts happen when multiple people work on the same file. In this case, there were two related PRs that were merged after you started working on this- Holly Worthen and Allison Jeon were both removed. You can either select the "Resolve conflicts" button below and manually edit the file so only Audreen's profile remains- delete the other two profiles as well as the "<<<<<<< add-audreen...", "======", ">>>>>> gh-pages"- and then commit the changes. Or you can also go to the your branch in your own repo and select "Sync fork". Either way if you have trouble let us know.

Thank you for working on this and great job again.

@github-project-automation github-project-automation bot moved this from PR Needs review to PRs being reviewed in P: HfLA Website: Project Board Jul 13, 2025
Copy link
Member

@santi-jose santi-jose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nubilaxl ! Great job submitting your first PR. It looks good!

  1. The title gives information at a glance to what issue the PR is addressing
  2. The into and from branches are correct
  3. Before and after pictures are included
  4. The code added to the file matches what is requested in the Issue

A couple changes I second from @t-will-gillis review:

  1. Check your PR for CodeQL alerts. These annotate any code which need review after you submit your PR. If you have any CodeQL alerts make sure to mark it accordingly within your PR in the checkbox section titled "CodeQL Alerts"
  2. Resolve merge conflicts in your feature branch add-audreen-fune-8014. As noted by @t-will-gillis , Holly Worthen and Allison Jeon were removed from the main branch after your PR was submitted. You need to resolve these merge conflicts. You can simply remove these two from the 311-data.md file in your feature branch, or I believe syncing your feature branch and pulling the latest changes would also fix this issue. Note that this may also remove the changes you made s.a. adding Audreen Fune to the 311-data leadership property. Therefore it may be simpler to resolve the merge conflicts one at a time by removing Holly Worthen and Allison Jeon from the 311 leadership property.

All in all, very solid work for your first PR. When you get the chance to make these changes I'll make sure to review again!

Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nubilaxl Thank you for resolving the merge conflict- looks good!

A couple minor notes-

  • For the "What changes did you make?" you can shorten this to
    - Added Audreen Fune to 311 Data project page
    
    The rest of the info is not needed. Just copy and insert the note above (with the dash at the start as shown.
  • On the original issue 8014, please check the boxes on the items you completed for the "Action Items"

Almost there - when you make these changes, be sure to re-request a review from both of us so that we know to look out for it.
Thanks for sticking with this!

Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nubilaxl Perfect- thanks so much

@t-will-gillis t-will-gillis merged commit 85080b2 into hackforla:gh-pages Aug 17, 2025
7 checks passed
Copy link
Member

@myronchen-git myronchen-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job.

  • The merge from and to branches are correct.
  • The issue is linked correctly.
  • The pull request info is filled out and has relevant screenshots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe

Projects

Development

Successfully merging this pull request may close these issues.

Update Project Profile: 311 Data Add Audreen Fune

5 participants