Skip to content

Conversation

@zvidmarb
Copy link
Member

@zvidmarb zvidmarb commented Jul 22, 2025

Fixes #7417

What changes did you make?

  • Update capitalization from github to GitHub on relevant method header

Why did you make the changes (we will use this info to test)?

  • To reflect correct branding for the GitHub company

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

  • No visual changes to the website

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b zvidmarb-github-uppercase-7417 gh-pages
git pull https://github.com/zvidmarb/HackforLA-Website.git github-uppercase-7417

@github-actions github-actions bot added good first issue Good for newcomers role: back end/devOps Tasks for back-end developers Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms size: 0.25pt Can be done in 0.5 to 1.5 hours Lang: GHA GitHub Actions labels Jul 22, 2025
@katiejnete katiejnete self-requested a review July 23, 2025 03:39
@katiejnete
Copy link
Member

ETA: EOD
Availability: Varying weekdays 7-9PM

Copy link
Member

@katiejnete katiejnete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @zvidmarb , thank you for taking on this issue.

Things you did well:

PR is done with the correct branch.
PR contains correctly formatted linked issue.
CodeQL Alerts have been properly checked.
PR follows correct format and is properly written.
The changes are applicable to the issue.
Website is still user-friendly and links and components still work as intended.
Source code changes are applicable.

Suggested changes:

None

Thank you for your hard work, I approve this PR.

@santi-jose
Copy link
Member

Review ETA: 12AM 7/25/2025
Availability: 8AM - 12PM PST

@santi-jose santi-jose self-requested a review July 25, 2025 05:27
Copy link
Member

@santi-jose santi-jose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @zvidmarb! Great work on completing this issue!

What you did right:

  1. The into and from branches are correct
  2. Properly linked the issue associated to the PR
  3. CodeQL Alerts properly checked
  4. Website is working as intended with changes
  5. The comment referencing GitHub was changed correctly from "github" to "GitHub"

Great work! I approve this PR

@github-project-automation github-project-automation bot moved this from PR Needs review to PRs ✅ waiting for merge team in P: HfLA Website: Project Board Jul 25, 2025
@mugdhchauhan
Copy link
Member

Nice one! Thanks for working on this. I have verified the changes are accurate and will now merge. 🎉

@mugdhchauhan mugdhchauhan merged commit 74e8578 into hackforla:gh-pages Jul 25, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms good first issue Good for newcomers Lang: GHA GitHub Actions role: back end/devOps Tasks for back-end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

Development

Successfully merging this pull request may close these issues.

Replace github with GitHub in github-actions/utils/post-issue-comment.js

4 participants