-
-
Notifications
You must be signed in to change notification settings - Fork 843
remove Srishti Gupta from Expunge Assist #8253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove Srishti Gupta from Expunge Assist #8253
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
ryanfkeller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @edwarddim, thanks for contributing!
The code change you made looks good -- there are just a couple things to address with the PR format:
- Please remove the unused bullets under the "What changes did you make?" and "Why did you make these changes?" sections.
- For the "Why did you make these changes?" section, the content should be the motivation for the code change as described in the issue (i.e. for this issue, to keep the Expunge Assist project information up to date). Please go ahead and update that bullet.
- Please check the appropriate tick box in the "Code QL Alerts" section.
Nice work with getting this PR out! Also, nice work with the before/after screenshots, those look great. To my eye this looks very close to done.
|
@ryanfkeller Thank you for the notes! I have made the requested edits. |
ryanfkeller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @edwarddim, looks great to me, I approve!
|
|
Availability: after 3pm (pacific) |
kdaca19xx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your efforts, edwarddim!
Things Done Well
-
The pull request was done with the correct branch.
-
There's a linked issue, and I understood it.
-
The change in the Files Changed tab look good!
-
Great job on making ryanfkeller's edit suggestions!
Suggestions
n/a
xnealcarson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, @edwarddim Many thanks for taking on this issue.
Things Done Well
- The issue has the correct 'commit into': "hackforla:gh-pages".
- the 'commit from' and 'collaborator' names match.
- The linked issue is present.
- The changes made are applicable and clean.
- Changes were viewable in browser.
Suggestions
none
Thanks again, @edwarddim. Keep up the great work!
Fixes #8002
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied