Skip to content

Conversation

@santiseccovidal
Copy link
Member

@santiseccovidal santiseccovidal commented Aug 15, 2025

Fixes #7527

What changes did you make?

  • Created new folder in github-actions/trigger-schedule named vrms-data
  • Built filter-vrms-data.js
  • Integrated file with vrms-data.yml workflow.

Why did you make the changes (we will use this info to test)?

  • Currently excessive amounts of information are being pulled into vrms-data.json
  • Different pages of the website then pull data from vrms-data.json but not all the data is being used, there's redundancy.
  • In this excessive information there's sensitive data like meeting passcodes, private links, etc.
  • By filtering the information we don't expose data that could be used for malicious purposes.

Note to reviewers

You need to test this on your repo and need to also pull the changes locally and check that the website remains unchanged after the changes. That is, by changing vrms-data.json the website works, that's what basically we'll be doing.

This guide might help GHA guide for setting up the testing environment and remember to default your branch to the new branch to test this. Also in vrms-data.yml replace "hackforla" with your github handle, in my case it was "santiseccovidal"

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b santiseccovidal-filter-vrms-7527 gh-pages
git pull https://github.com/santiseccovidal/website.git filter-vrms-7527

@github-actions github-actions bot added role: back end/devOps Tasks for back-end developers Complexity: Large size: 5pt Can be done in 19-30 hours Feature: API Coding requires using an API labels Aug 15, 2025
Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @santiseccovidal This looks great! I ran this in my repo and vrms_data.json is significantly smaller than before. I checked Events, Project Meetings, and individual project pages and it appears to me that those pages render the same as before but the JSON is no longer saving some of the sensitive data / meetings or extraneous data.

The only minor notes are about the CodeQL saying that const path = require('path'); is unused because it is commented out, so probably best to delete the comments and the constant..

Thanks for working on this!

@github-project-automation github-project-automation bot moved this from PR Needs review to PRs being reviewed in P: HfLA Website: Project Board Aug 25, 2025
Remove unused comment and redundant comment
@santiseccovidal
Copy link
Member Author

Hi @t-will-gillis I removed the unused module and deleted the redundant comment.
Thanks for the review

Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @santiseccovidal Thanks for resolving the CodeQL alert. Everything looks good to me.

  • Sorry I did not think of this the first time, but regarding the Merge Conflict: I think the easiest way to resolve this will be to remove vrms_data.json from your commit since that file will be overwritten by the new workflow anyway.

@santiseccovidal
Copy link
Member Author

@t-will-gillis thanks Will, I just reverted the changes to vrms_data.json

Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @santiseccovidal for clearing up the merge conflict!

@t-will-gillis
Copy link
Member

Hi @santiseccovidal took one last look at this in Docker. All website pages: meeting schedules, links, etc. appear to work as intended. Great work!

@t-will-gillis t-will-gillis merged commit 60ba05e into hackforla:gh-pages Sep 18, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complexity: Large Feature: API Coding requires using an API Lang: GHA GitHub Actions role: back end/devOps Tasks for back-end developers size: 5pt Can be done in 19-30 hours Skill: enhance

Projects

Development

Successfully merging this pull request may close these issues.

Enhance GHA: Update VMRS data to fetch required data

3 participants