-
-
Notifications
You must be signed in to change notification settings - Fork 843
Enhance GHA: Update VMRS data to fetch required data #8275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance GHA: Update VMRS data to fetch required data #8275
Conversation
Changed github.repository condition from santiseccovidal back to hackforla
Fix filter to keep nested project structure (no more "project.name" flat keys)
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
t-will-gillis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @santiseccovidal This looks great! I ran this in my repo and vrms_data.json is significantly smaller than before. I checked Events, Project Meetings, and individual project pages and it appears to me that those pages render the same as before but the JSON is no longer saving some of the sensitive data / meetings or extraneous data.
The only minor notes are about the CodeQL saying that const path = require('path'); is unused because it is commented out, so probably best to delete the comments and the constant..
Thanks for working on this!
Remove unused comment and redundant comment
|
Hi @t-will-gillis I removed the unused module and deleted the redundant comment. |
t-will-gillis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @santiseccovidal Thanks for resolving the CodeQL alert. Everything looks good to me.
- Sorry I did not think of this the first time, but regarding the Merge Conflict: I think the easiest way to resolve this will be to remove
vrms_data.jsonfrom your commit since that file will be overwritten by the new workflow anyway.
|
@t-will-gillis thanks Will, I just reverted the changes to |
t-will-gillis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @santiseccovidal for clearing up the merge conflict!
|
Hi @santiseccovidal took one last look at this in Docker. All website pages: meeting schedules, links, etc. appear to work as intended. Great work! |
Fixes #7527
What changes did you make?
github-actions/trigger-schedulenamedvrms-datafilter-vrms-data.jsvrms-data.ymlworkflow.Why did you make the changes (we will use this info to test)?
vrms-data.jsonvrms-data.jsonbut not all the data is being used, there's redundancy.Note to reviewers
You need to test this on your repo and need to also pull the changes locally and check that the website remains unchanged after the changes. That is, by changing
vrms-data.jsonthe website works, that's what basically we'll be doing.This guide might help GHA guide for setting up the testing environment and remember to default your branch to the new branch to test this. Also in
vrms-data.ymlreplace "hackforla" with your github handle, in my case it was "santiseccovidal"CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)