Skip to content

Conversation

@myronchen-git
Copy link
Member

@myronchen-git myronchen-git commented Aug 16, 2025

Fixes #7335

What changes did you make?

  • In _projects/youthjusticenav.md, added a key, github-handle, to the leadership item, Hyun Joo Sandy Oh.

Why did you make the changes (we will use this info to test)?

  • We need to create a single variable github-handle to hold the github handle for each member of the leadership team. Eventually github-handle will replace the github and picture variables, reducing redundancy in the project file.

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

  • No visual changes to the website

We need to create a single variable github-handle to hold the github
handle for each member of the leadership team. Eventually github-handle
will replace the github and picture variables, reducing redundancy in
the project file.

In _projects/youthjusticenav.md, this is done by adding a key,
github-handle, to the leadership item, Hyun Joo Sandy Oh.
@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b myronchen-git-add-github-handle-7335 gh-pages
git pull https://github.com/myronchen-git/website.git add-github-handle-7335

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Aug 16, 2025
@kdaca19xx
Copy link
Member

Availability: daily after 1pm (pacific)
ETA: 8/18

@kelwilson kelwilson self-requested a review August 18, 2025 09:39
@kelwilson
Copy link
Member

Review ETA: 10AM
Availability: 8/18/25

@xnealcarson
Copy link
Member

Availability: After 3pm PST
ETA: 8/19/2025

Copy link
Member

@kdaca19xx kdaca19xx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, myronchen-git! I'd like to approve your PR.

Things Done Well

  • The pull request was done with the correct branch.

  • There's a linked issue. It took a sec for me to catch that "key" in your PR means "variable" in #7335, but I understood.

  • I appreciate you identifying the file name under "What changes did you make?" even though it's in the Files Changed tab.

  • The addition you made in the Files Changed tab look good!

Suggestions

n/a

Copy link
Member

@xnealcarson xnealcarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, @myronchen-git ! Thank you for working on this issue.

Things Done Well

  • The issue has the correct 'commit into': "hackforla:gh-pages".
  • the 'commit from' and 'collaborator' names match.
  • The linked issue is present.
  • The changes made are applicable and clean.

Suggestions

none

Thanks again, @myronchen-git !

@github-project-automation github-project-automation bot moved this from PR Needs review to PRs ✅ waiting for merge team in P: HfLA Website: Project Board Aug 18, 2025
Copy link
Member

@santiseccovidal santiseccovidal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @myronchen-git branches are correct, what and why sections are clear and code is good. Also when testing in Docker the website works correctly.
Thanks for working on this.

Copy link
Member

@kelwilson kelwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @myronchen-git, Thanks for working on this issue

Things Done Well

  • The pull request was made into the correct branch "hackforla:gh-pages"
  • The issue was correctly linked, keeping the workflow organized.
  • The variable name was properly replaced, reducing redundancy and improving consistency in the project file.
  • The changes were well-implemented and didn’t break the website.

Suggestions

  • None

Overall, this is a clean and thoughtful contribution. Thanks for contributing 😇!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

Development

Successfully merging this pull request may close these issues.

Add github-handle for Hyun Joo Sandy Oh in youthjusticenav.md

6 participants