-
-
Notifications
You must be signed in to change notification settings - Fork 843
refactor: add github-handle for Youth Justice Nav #8276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: add github-handle for Youth Justice Nav #8276
Conversation
We need to create a single variable github-handle to hold the github handle for each member of the leadership team. Eventually github-handle will replace the github and picture variables, reducing redundancy in the project file. In _projects/youthjusticenav.md, this is done by adding a key, github-handle, to the leadership item, Hyun Joo Sandy Oh.
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Availability: daily after 1pm (pacific) |
|
Review ETA: 10AM |
|
Availability: After 3pm PST |
kdaca19xx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, myronchen-git! I'd like to approve your PR.
Things Done Well
-
The pull request was done with the correct branch.
-
There's a linked issue. It took a sec for me to catch that "key" in your PR means "variable" in #7335, but I understood.
-
I appreciate you identifying the file name under "What changes did you make?" even though it's in the Files Changed tab.
-
The addition you made in the Files Changed tab look good!
Suggestions
n/a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, @myronchen-git ! Thank you for working on this issue.
Things Done Well
- The issue has the correct 'commit into': "hackforla:gh-pages".
- the 'commit from' and 'collaborator' names match.
- The linked issue is present.
- The changes made are applicable and clean.
Suggestions
none
Thanks again, @myronchen-git !
santiseccovidal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @myronchen-git branches are correct, what and why sections are clear and code is good. Also when testing in Docker the website works correctly.
Thanks for working on this.
kelwilson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work @myronchen-git, Thanks for working on this issue
Things Done Well
- The pull request was made into the correct branch "hackforla:gh-pages"
- The issue was correctly linked, keeping the workflow organized.
- The variable name was properly replaced, reducing redundancy and improving consistency in the project file.
- The changes were well-implemented and didn’t break the website.
Suggestions
- None
Overall, this is a clean and thoughtful contribution. Thanks for contributing 😇!
Fixes #7335
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)