Skip to content

Conversation

@myronchen-git
Copy link
Member

@myronchen-git myronchen-git commented Aug 20, 2025

Fixes #8238

What changes did you make?

  • Removed Siyun Feng from leadership on the website project profile.

Why did you make the changes (we will use this info to test)?

  • To keep project information up-to-date, so that it remains accurate for visitors.

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied Screenshot 2025-08-20 at 12-07-26 Hack for LA Site - Hack for LA
Visuals after changes are applied Screenshot 2025-08-20 at 12-08-55 Hack for LA Site - Hack for LA

Removed Siyun Feng from leadership on the website project profile.
@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b myronchen-git-update-project-profile-8238 gh-pages
git pull https://github.com/myronchen-git/website.git update-project-profile-8238

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Aug 20, 2025
@mugdhchauhan mugdhchauhan requested review from k-cardon, kdaca19xx and xnealcarson and removed request for k-cardon August 24, 2025 17:11
@kdaca19xx
Copy link
Member

Availability:
Mon-Sun after 1pm (pacific)

ETA:
8/25/25

@xnealcarson
Copy link
Member

Availability:
After 4pm PST

ETA:
8/26/25 by the end of the day

kdaca19xx
kdaca19xx previously approved these changes Aug 26, 2025
Copy link
Member

@kdaca19xx kdaca19xx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Way to go, myronchen-git!

Things Done Well

  • The pull request was done with the correct branch.

  • There's a linked issue, and I understood it.

  • Your deletion shown in the Files Changed tab look good, and I can see the changes in Docker.

Suggestions

n/a

xnealcarson
xnealcarson previously approved these changes Aug 26, 2025
Copy link
Member

@xnealcarson xnealcarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, @myronchen-git ! Thank you for working on this issue.

Things Done Well

  • The issue has the correct 'commit into': "hackforla:gh-pages".
  • the 'commit from' and 'collaborator' names match.
  • The linked issue is present.
  • The changes made are applicable and clean.
  • Changes were viewable in browser.

##Suggestions

none

Thanks again @myronchen-git . Great work!

@github-project-automation github-project-automation bot moved this from PR Needs review to PRs ✅ waiting for merge team in P: HfLA Website: Project Board Aug 26, 2025
@t-will-gillis t-will-gillis dismissed stale reviews from xnealcarson and kdaca19xx via 07427e8 August 29, 2025 18:46
@t-will-gillis
Copy link
Member

t-will-gillis commented Aug 29, 2025

@myronchen-git A merge conflict just came up b/c just merged 8285. Since you have been waiting, and since you previously had Approvals from @kdaca19xx and @xnealcarson I resolved the conflict and am merging this.

@t-will-gillis t-will-gillis merged commit 0a222d3 into hackforla:gh-pages Aug 29, 2025
3 checks passed
@myronchen-git myronchen-git deleted the update-project-profile-8238 branch August 30, 2025 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe

Projects

Development

Successfully merging this pull request may close these issues.

Update Project Profile: Website: Remove Siyun Feng

4 participants