-
-
Notifications
You must be signed in to change notification settings - Fork 843
chore: update website project profile #8283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update website project profile #8283
Conversation
Removed Siyun Feng from leadership on the website project profile.
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Availability: ETA: |
|
Availability: ETA: |
kdaca19xx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Way to go, myronchen-git!
Things Done Well
-
The pull request was done with the correct branch.
-
There's a linked issue, and I understood it.
-
Your deletion shown in the Files Changed tab look good, and I can see the changes in Docker.
Suggestions
n/a
xnealcarson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, @myronchen-git ! Thank you for working on this issue.
Things Done Well
- The issue has the correct 'commit into': "hackforla:gh-pages".
- the 'commit from' and 'collaborator' names match.
- The linked issue is present.
- The changes made are applicable and clean.
- Changes were viewable in browser.
##Suggestions
none
Thanks again @myronchen-git . Great work!
07427e8
|
@myronchen-git A merge conflict just came up b/c just merged 8285. Since you have been waiting, and since you previously had Approvals from @kdaca19xx and @xnealcarson I resolved the conflict and am merging this. |
Fixes #8238
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied