Skip to content

Conversation

@lastCoyotes
Copy link
Member

@lastCoyotes lastCoyotes commented Aug 20, 2025

Fixes #8244

What changes did you make?

  • Removed J Pham's entry in leadership in website.md

Why did you make the changes (we will use this info to test)?

  • To keep project information up to date so that visitors to the website can find accurate information.

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied undefined - Imgur (1)
Visuals after changes are applied undefined - Imgur

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b lastCoyotes-remove-jpham-website-8244 gh-pages
git pull https://github.com/lastCoyotes/website.git remove-jpham-website-8244

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Aug 20, 2025
@kelwilson kelwilson self-requested a review August 22, 2025 09:21
@kelwilson
Copy link
Member

Review ETA: 8/22/25
Availability: 10: 00AM

Copy link
Member

@myronchen-git myronchen-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job.

  • The merge from and to branches are correct.

  • The issue is linked correctly.

  • The pull request info is filled out and has relevant screenshots.

  • On the linked issue, the action items haven't been checked off. I believe it is fine for first issues, but I think Hack For LA would want you to check them off.

@daras-cu
Copy link
Member

@kelwilson Can you please update us with your ETA for a review, or if you are not able to complete one please unassign yourself. Thank you

Copy link
Member

@santiseccovidal santiseccovidal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lastCoyotes everything is correct. Branches, why/what sections, code changes and changes in docker work as expected.
Well done

@github-project-automation github-project-automation bot moved this from PR Needs review to PRs ✅ waiting for merge team in P: HfLA Website: Project Board Aug 27, 2025
Copy link
Member

@kelwilson kelwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @lastCoyotes, Thanks for working on this issue

Things Done Well

  • The pull request was made into the correct branch "hackforla:gh-pages"
  • The issue was correctly linked, keeping the workflow organized.
  • The J Pham entry was properly removed from the leadership variable on the website.md file.
  • The changes were well-implemented and didn’t break the website.

Suggestions
None


Overall, this is a clean and thoughtful contribution. Thanks for contributing 😇!

@t-will-gillis t-will-gillis merged commit 330c49c into hackforla:gh-pages Aug 29, 2025
11 checks passed
@lastCoyotes lastCoyotes deleted the remove-jpham-website-8244 branch October 4, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe

Projects

Development

Successfully merging this pull request may close these issues.

Update Project Profile: Website- Remove J Pham

6 participants