-
-
Notifications
You must be signed in to change notification settings - Fork 843
Removed J Pham from website.md leadership list. #8285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed J Pham from website.md leadership list. #8285
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Review ETA: 8/22/25 |
myronchen-git
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job.
-
The merge from and to branches are correct.
-
The issue is linked correctly.
-
The pull request info is filled out and has relevant screenshots.
-
On the linked issue, the action items haven't been checked off. I believe it is fine for first issues, but I think Hack For LA would want you to check them off.
|
@kelwilson Can you please update us with your ETA for a review, or if you are not able to complete one please unassign yourself. Thank you |
santiseccovidal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @lastCoyotes everything is correct. Branches, why/what sections, code changes and changes in docker work as expected.
Well done
kelwilson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work @lastCoyotes, Thanks for working on this issue
Things Done Well
- The pull request was made into the correct branch "hackforla:gh-pages"
- The issue was correctly linked, keeping the workflow organized.
- The J Pham entry was properly removed from the leadership variable on the website.md file.
- The changes were well-implemented and didn’t break the website.
Suggestions
None
Overall, this is a clean and thoughtful contribution. Thanks for contributing 😇!
Fixes #8244
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied