Skip to content

Conversation

@gabbyjimenez
Copy link
Member

@gabbyjimenez gabbyjimenez commented Aug 26, 2025

Fixes #8287

What changes did you make?

  • Removed Terence Lo

Why did you make the changes (we will use this info to test)?

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied

image

Visuals after changes are applied

image

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b gabbyjimenez-8287 gh-pages
git pull https://github.com/gabbyjimenez/website.git 8287

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe Ready for Prioritization size: 0.25pt Can be done in 0.5 to 1.5 hours labels Aug 26, 2025
@myronchen-git
Copy link
Member

Hi Gabriela.

There are multiple problems with your pull request, from the title, to the information filled out, to the issue choice. The original issue is not ready for you work on yet, as hinted by this comment.

Please close this pull request. Then please read sections
"4 - FINDING AND ASSIGNING YOUR FIRST GITHUB ISSUE (GFI)"
and
"6 - SUBMITTING YOUR FIRST PULL REQUEST"
and the relevant pieces in the links within them, from your prework issue page.

@daras-cu
Copy link
Member

@gabbyjimenez thank you for working on this, but it looks like the originating issue for this PR, #8287 was still in the New Issue Approval column on the project board and not ready to be assigned yet. I'm going to close this PR, please unassign yourself from that issue and choose a new one from this column: Prioritized Backlog - Good First Issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) Ready for Prioritization role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe

Projects

Development

Successfully merging this pull request may close these issues.

Update Project Profile: Civic Tech Jobs Remove Terence Lo

3 participants