-
-
Notifications
You must be signed in to change notification settings - Fork 843
Updated Project Profile Civic-Tech: Removed Manju Chawla #8300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Project Profile Civic-Tech: Removed Manju Chawla #8300
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Review ETA: 6PM 8/28/2025 |
myronchen-git
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Edward. Good work on completing this good first issue.
- The merge into and from branches are correct.
- The originating issue is correctly linked.
Changes needed:
- In your pull request description, there is a missing CodeQL Alerts section. Please put that in and check off the appropriate response. You can find the text for that in a new pull request draft or from another pull request.
- In the originating issue, you should not close the issue. I believe that is done by the merge team.
- In the originating issue, it is not recommended to attach screenshots of your code. Changes in code can easily be viewed in the pull request "Files changed" tab.
|
Availability: 5 PM - 7 PM everyday |
|
Availability: after 1pm (pacific) |
|
Availability: After 4pm PST |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @devxed43 ! Good job on this Good First Issue!
What you did well:
- Into and from branches are correct.
- Issue is linked correctly.
- Properly updated checkbox tasks in original issue.
- Pull Request states what changes in the website.
- Pull Request states why changes are made in the website.
- Pictures were included to show the visual effects of the changes from before and after the updates.
- Proper changes made in code.
- Changes in code don't break the website.
Changes requested:
- I second all the recommended changes suggested by @myronchen-git.
a. Add the CodeQL Alerts section from the initial Pull Request template.
b. Don't close the original issue.
c. Don't add screenshots to the original issue comments section, as you will be able to add them to the Pull Request itself.
Otherwise great job! When the requested changes are made, re-request a review and I'll check it again.
Extra:
A bit of a nitpick, but I think you can be a bit more descriptive in the PR title. For future PR's I suggest a more specific title like: Updated Project Profile-Civic Tech: Removed Manju Chawla
|
Fixes #8108 What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts |
myronchen-git
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making the changes. Although you missed some things.
Instead of making a new comment with the CodeQL alert section, could you please edit your first post at the top of this pull request? Just click on the three dots at the top right of the post and click edit.
Also, the CodeQL alert section you inserted only has the section title. Please use the code below for the alerts section.
<h3>CodeQL Alerts</h3>
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
<details><summary>Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown</summary>

</details>
Please let us know that you have checked for CodeQL alerts. **Please do not dismiss alerts.**
- [x] I have checked this PR for CodeQL alerts and none were found.
- [ ] I found CodeQL alert(s), and (select one):
- [ ] I have resolved the CodeQL alert(s) as noted
- [ ] I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
- [ ] I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
<details><summary>Instructions for resolving CodeQL alerts</summary>
If CodeQL alert/annotations appear, refer to [How to Resolve CodeQL alerts](https://github.com/hackforla/website/issues/6463#issuecomment-2002573270).
In general, CodeQL alerts should be resolved prior to PR reviews and merging
</details>
In the originating issue, you can reopen it by going to the bottom of the page, and in the Add a comment area, click on the Reopen issue button. Ensure that you also update the status of the issue by going to the right sidebar, under Projects, under Project Board, set the status to In progress.
I need to reach out to someone about a Git issue keeping me from doing this review and meeting my original deadline. My new ETA is 8/31. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, @devxed43 ! MThnaks for working on this issue
Things Done Well
- The issue has the correct 'commit into': "hackforla:gh-pages".
- the 'commit from' and 'collaborator' names match.
- The linked issue is present.
- The changes made are applicable and clean.
- Changes were viewable in browser.
Suggestions
None, as it appears that you have addressed the requested changes from @myronchen-git and @santi-jose.
Great job and thanks again, @devxed43!
myronchen-git
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes. Everything looks fine now.
- The pull request description is filled out correctly, as the what and why is filled, the CodeQL section is filled, and the screenshots of changes are given.
- In the originating issue, the status is correctly set to In progress.
santi-jose
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @devxed43 ! Thanks for making the suggested change to the PR titile. You also addressed all changes requested by @myronchen-git, so I aprove the review. Great work!


Fixes #8108
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Visuals before changes are applied
Visuals after changes are applied