Skip to content

Conversation

@devxed43
Copy link
Member

@devxed43 devxed43 commented Aug 27, 2025

Fixes #8108

What changes did you make?

  • Deleted Manju Chawla via civic tech jobs md file
  • Deleted Manju Chawla from hackforla's civic tech jobs page

Why did you make the changes (we will use this info to test)?

  • To help keep hackforla's civic tech jobs project up-to-date

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Visuals before changes are applied before
Visuals after changes are applied after

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b devxed43-update-project-profile-8108 gh-pages
git pull https://github.com/devxed43/website.git update-project-profile-8108

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Aug 27, 2025
@santi-jose santi-jose self-assigned this Aug 27, 2025
@santi-jose
Copy link
Member

Review ETA: 6PM 8/28/2025
Availability: 5-8PM Monday - Thursday

@myronchen-git myronchen-git self-requested a review August 27, 2025 23:10
Copy link
Member

@myronchen-git myronchen-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Edward. Good work on completing this good first issue.


  • The merge into and from branches are correct.
  • The originating issue is correctly linked.

Changes needed:

  • In your pull request description, there is a missing CodeQL Alerts section. Please put that in and check off the appropriate response. You can find the text for that in a new pull request draft or from another pull request.
  • In the originating issue, you should not close the issue. I believe that is done by the merge team.
  • In the originating issue, it is not recommended to attach screenshots of your code. Changes in code can easily be viewed in the pull request "Files changed" tab.

@github-project-automation github-project-automation bot moved this from PR Needs review to PRs being reviewed in P: HfLA Website: Project Board Aug 27, 2025
@myronchen-git
Copy link
Member

Availability: 5 PM - 7 PM everyday

@kdaca19xx kdaca19xx self-requested a review August 28, 2025 01:08
@xnealcarson xnealcarson self-requested a review August 28, 2025 01:09
@kdaca19xx
Copy link
Member

Availability: after 1pm (pacific)
ETA: 8/29

@xnealcarson
Copy link
Member

Availability: After 4pm PST
ETA: 8/29 by end of day

Copy link
Member

@santi-jose santi-jose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @devxed43 ! Good job on this Good First Issue!

What you did well:

  1. Into and from branches are correct.
  2. Issue is linked correctly.
  3. Properly updated checkbox tasks in original issue.
  4. Pull Request states what changes in the website.
  5. Pull Request states why changes are made in the website.
  6. Pictures were included to show the visual effects of the changes from before and after the updates.
  7. Proper changes made in code.
  8. Changes in code don't break the website.

Changes requested:

  1. I second all the recommended changes suggested by @myronchen-git.
    a. Add the CodeQL Alerts section from the initial Pull Request template.
    b. Don't close the original issue.
    c. Don't add screenshots to the original issue comments section, as you will be able to add them to the Pull Request itself.

Otherwise great job! When the requested changes are made, re-request a review and I'll check it again.

Extra:
A bit of a nitpick, but I think you can be a bit more descriptive in the PR title. For future PR's I suggest a more specific title like: Updated Project Profile-Civic Tech: Removed Manju Chawla

@devxed43 devxed43 changed the title Updated Project Profile: Removed Manju Chawla Updated Project Profile Civic-Tech: Removed Manju Chawla Aug 28, 2025
@devxed43
Copy link
Member Author

Fixes #8108

What changes did you make?

  • Deleted Manju Chawla via civic tech jobs md file
  • Deleted Manju Chawla from hackforla's civic tech jobs page

Why did you make the changes (we will use this info to test)?

  • To help keep hackforla's civic tech jobs project up-to-date

CodeQL Alerts

Visuals before changes are applied before
Visuals after changes are applied after

Copy link
Member

@myronchen-git myronchen-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the changes. Although you missed some things.


Instead of making a new comment with the CodeQL alert section, could you please edit your first post at the top of this pull request? Just click on the three dots at the top right of the post and click edit.

Also, the CodeQL alert section you inserted only has the section title. Please use the code below for the alerts section.

<h3>CodeQL Alerts</h3>


After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.


<details><summary>Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown</summary>
  
![Screenshot 2024-10-28 154514](https://github.com/user-attachments/assets/ea66c586-c14c-45fd-8705-1c116224e704)


</details>

Please let us know that you have checked for CodeQL alerts. **Please do not dismiss alerts.**
- [x] I have checked this PR for CodeQL alerts and none were found.
- [ ] I found CodeQL alert(s), and (select one):
   - [ ] I have resolved the CodeQL alert(s) as noted
   - [ ] I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
   - [ ] I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)

<details><summary>Instructions for resolving CodeQL alerts</summary>

If CodeQL alert/annotations appear, refer to [How to Resolve CodeQL alerts](https://github.com/hackforla/website/issues/6463#issuecomment-2002573270).  

In general, CodeQL alerts should be resolved prior to PR reviews and merging

</details>

In the originating issue, you can reopen it by going to the bottom of the page, and in the Add a comment area, click on the Reopen issue button. Ensure that you also update the status of the issue by going to the right sidebar, under Projects, under Project Board, set the status to In progress.

@kdaca19xx
Copy link
Member

Availability: after 1pm (pacific) ETA: 8/29

I need to reach out to someone about a Git issue keeping me from doing this review and meeting my original deadline.

My new ETA is 8/31.

Copy link
Member

@xnealcarson xnealcarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, @devxed43 ! MThnaks for working on this issue

Things Done Well

  • The issue has the correct 'commit into': "hackforla:gh-pages".
  • the 'commit from' and 'collaborator' names match.
  • The linked issue is present.
  • The changes made are applicable and clean.
  • Changes were viewable in browser.

Suggestions

None, as it appears that you have addressed the requested changes from @myronchen-git and @santi-jose.

Great job and thanks again, @devxed43!

Copy link
Member

@myronchen-git myronchen-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes. Everything looks fine now.

  • The pull request description is filled out correctly, as the what and why is filled, the CodeQL section is filled, and the screenshots of changes are given.
  • In the originating issue, the status is correctly set to In progress.

Copy link
Member

@santi-jose santi-jose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @devxed43 ! Thanks for making the suggested change to the PR titile. You also addressed all changes requested by @myronchen-git, so I aprove the review. Great work!

@github-project-automation github-project-automation bot moved this from PRs being reviewed to PRs ✅ waiting for merge team in P: HfLA Website: Project Board Aug 31, 2025
@t-will-gillis t-will-gillis merged commit 3c3eccc into hackforla:gh-pages Aug 31, 2025
11 checks passed
@devxed43 devxed43 deleted the update-project-profile-8108 branch August 31, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe

Projects

Development

Successfully merging this pull request may close these issues.

Update Project Profile: Civic Tech Jobs - Remove Manju Chawla

6 participants