Skip to content

Update Civic Tech Jobs project profile webpage #8304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
t-will-gillis merged 1 commit into from
Sep 3, 2025
Merged

Update Civic Tech Jobs project profile webpage #8304

t-will-gillis merged 1 commit into from
Sep 3, 2025

Conversation

@myronchen-git
Copy link
Member

@myronchen-git myronchen-git commented Aug 30, 2025

Fixes #8084

What changes did you make?

  • Removed Kanika Chotani and Jimmy Juarez from the Civic Tech Jobs webpage's leadership.

Why did you make the changes (we will use this info to test)?

  • To keep the page up-to-date so that visitors are viewing accurate information. Those two are no longer in leadership or no longer active in Hack for LA.

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied Screenshot 2025-08-30 at 12-55-02 Civic Tech Jobs - Hack for LA
Visuals after changes are applied Screenshot 2025-08-30 at 12-55-23 Civic Tech Jobs - Hack for LA

@myronchen-git
chore: update civic tech jobs project profile
95c9f45 
Removed Kanika Chotani and Jimmy Juarez from the Civic Tech Jobs
webpage's leadership.  This is done to keep the page up-to-date,
because either those two are no longer in leadership or no longer
active in Hack for LA.
@github-actions
Copy link

github-actions bot commented Aug 30, 2025

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b myronchen-git-update-civic-tech-jobs-project-profile-8084 gh-pages
git pull https://github.com/myronchen-git/website.git update-civic-tech-jobs-project-profile-8084

@github-actions github-actions bot added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 0.25pt Can be done in 0.5 to 1.5 hours labels Aug 30, 2025
@HackforLABot HackforLABot mentioned this pull request Aug 31, 2025
Open
@caz002 caz002 self-requested a review August 31, 2025 05:30
@FatCatLikesBeer FatCatLikesBeer self-requested a review August 31, 2025 05:34
@FatCatLikesBeer
Copy link
Member

FatCatLikesBeer commented Aug 31, 2025

  1. Availability: Mon-Sun 6pm-11pm PST
  2. ETA: Tuesday, 9/2

@HackforLABot HackforLABot mentioned this pull request Aug 31, 2025
Open
@caz002
Copy link
Member

caz002 commented Aug 31, 2025

Review ETA: 8/31/25
Availability: after 7pm on Weekdays

@HackforLABot HackforLABot mentioned this pull request Aug 31, 2025
Open
caz002
caz002 approved these changes Aug 31, 2025
View reviewed changes
Copy link
Member

@caz002 caz002 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this issue @myronchen-git !

Things Done Well

  • Code passes all Code QL alerts
  • PR description accurately describes changes and why they were made
  • Only the requested file in the issue was changed
  • Changes appear on the website and line up with what was asked in the instructions

Requested Changes

None

I approve this PR.

Edit: There is also a CodeQL error for "Memory Activity Trigger" that popped up after I reviewed the PR, I'm not sure if it was because of your code though. I messaged Will to ask for more information.

@myronchen-git
Copy link
Member Author

myronchen-git commented Aug 31, 2025 •
edited
Loading

Thank you for working on this issue @myronchen-git !

Things Done Well

* Code passes all Code QL alerts

* PR description accurately describes changes and why they were made

* Only the requested file in the issue was changed

* Changes appear on the website and line up with what was asked in the instructions

Requested Changes

None

I approve this PR.

Edit: There is also a CodeQL error for "Memory Activity Trigger" that popped up after I reviewed the PR, I'm not sure if it was because of your code though. I messaged Will to ask for more information.

Thanks for messaging someone about it. I don't know what that is about. Looking into the raw log gives an error of

Error: Input required and not supplied: github-token

I think I read about a similar problem like that happening to someone else, but I do not remember where that was.

@t-will-gillis t-will-gillis self-requested a review September 2, 2025 18:44
t-will-gillis
t-will-gillis reviewed Sep 2, 2025
View reviewed changes
Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @myronchen-git @caz002 @FatCatLikesBeer

As a confirmation- the "Member Activity Trigger" error can be ignored for this PR review.

FatCatLikesBeer
FatCatLikesBeer approved these changes Sep 3, 2025
View reviewed changes
Copy link
Member

@FatCatLikesBeer FatCatLikesBeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@myronchen-git thank you for taking on this PR!

Things Done Well

  • Pull request is done in the correct branch
  • Issue is properly linked and understandable
  • Issue appears to be don with the correct branch
  • Appropriate changes reflected in Files changed tab
  • Relevant screen shots are correctly placed
  • Website still works as expected
  • Expected changes are reflected in the website 👍🏽

Requested Changes

  • None

Notes

I approve this PR!

@github-project-automation github-project-automation bot moved this from PR Needs review to PRs ✅ waiting for merge team in P: HfLA Website: Project Board Sep 3, 2025
@t-will-gillis t-will-gillis merged commit c9bb11d into hackforla:gh-pages Sep 3, 2025
7 of 11 checks passed
@HackforLABot HackforLABot mentioned this pull request Sep 3, 2025
Open
34 tasks
@myronchen-git myronchen-git deleted the update-civic-tech-jobs-project-profile-8084 branch September 6, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@t-will-gillis t-will-gillis t-will-gillis left review comments

@FatCatLikesBeer FatCatLikesBeer FatCatLikesBeer approved these changes

@caz002 caz002 caz002 approved these changes

Assignees

No one assigned

Labels

Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe

Projects

P: HfLA Website: Project Board
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update Project Profile: Civic Tech Jobs Remove Kanika Chotani and Jimmy Juarez

4 participants

@myronchen-git @FatCatLikesBeer @caz002 @t-will-gillis