Remove Extraneous $ in wins.js
#8305
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8289
What changes did you make?
$and typo in thewins.jsfileWhy did you make the changes (we will use this info to test)?
website/assets/js/wins.jsfile on line 31 to exclude the invalid$character in order to prevent the wins page from crashing.community.svgicon (website/assets/images/wins-page/wins-badges/community.svg) displays under the developer’s summary section if "I became part of a caring community" is included in the "What do you want to celebrate (select all that apply)?" field inwebsite/_data/external/_wins-data.json.Test Procedure
website/_data/external/_wins-data.jsonfiledocker-compose upfrom a terminal windowhttps://localhost:4000/winsin your browser windowcommunity.svgiconwebsite/_data/external/_wins-data.jsonfile and saveCodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Relevant Screenshots
Visuals before testing changes are applied
Visuals after testing changes are applied