Skip to content

Conversation

@lc1715
Copy link
Member

@lc1715 lc1715 commented Aug 31, 2025

Fixes #8289

What changes did you make?

  • Removed the extraneous $ and typo in the wins.js file

Why did you make the changes (we will use this info to test)?

  • We need to update the website/assets/js/wins.js file on line 31 to exclude the invalid $ character in order to prevent the wins page from crashing.
  • We also need to ensure the community.svg icon (website/assets/images/wins-page/wins-badges/community.svg) displays under the developer’s summary section if "I became part of a caring community" is included in the "What do you want to celebrate (select all that apply)?" field in website/_data/external/_wins-data.json.

Test Procedure

  1. Go to the website/_data/external/_wins-data.json file
  2. Add the testing object below as the last item in the array and save it
{
          "Timestamp": "2025-08-29T00:40:59.045Z",
          "Email Address": "[email protected]",
          "Full name": "Testing",
          "Linkedin URL (optional)": "https://www.linkedin.com",
          "Could we use your Linkedin profile picture next to your story?": "Yes",
          "Github URL (optional)": "https://github.com",
          "Could we use your Github profile picture next to your story?": "No",
          "Select the team(s) you're on": "HackforLA Website",
          "Select your role(s) on the team": "Development",
          "What is/was your specific role? (optional)": "test",
          "When did you join Hack for LA? (optional)": "2023-08-11T07:00:00.000Z",
          "What do you want to celebrate (select all that apply)?": "I got a new job, I produced something for my portfolio, I improved my LinkedIn, I became part of a caring community",
          "Give us a brief overview": "Test response",
          "Display?": true,
          "Homepage?": false
     }
  1. Open the Docker Desktop application and run the command docker-compose up from a terminal window
  2. View the changes on the wins page at https://localhost:4000/wins in your browser window
  3. The community.svg icon community.svg icon should display under the developer’s summary section
  4. Remove the testing object from the website/_data/external/_wins-data.json file and save

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Relevant Screenshots

Visuals before testing changes are applied wins page before testing changes
Visuals after testing changes are applied wins page after testing changes detailed information about the individual

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b lc1715-remove-extraneous-ehBwins.js-8289 gh-pages
git pull https://github.com/lc1715/website.git remove-extraneous-ehBwins.js-8289

@github-actions github-actions bot added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Complexity: Medium time sensitive Needs to be worked on by a particular timeframe P-Feature: Wins Page https://www.hackforla.org/wins/ size: 0.5pt Can be done in 3 hours or less labels Aug 31, 2025
@lc1715 lc1715 closed this Aug 31, 2025
@lc1715
Copy link
Member Author

lc1715 commented Aug 31, 2025

Renamed the topic branch and closed this PR. Please see the new PR #8306 for the updated changes.

@lc1715 lc1715 deleted the remove-extraneous-$-wins.js-8289 branch August 31, 2025 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complexity: Medium P-Feature: Wins Page https://www.hackforla.org/wins/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less time sensitive Needs to be worked on by a particular timeframe

Projects

Development

Successfully merging this pull request may close these issues.

Remove Extraneous $ in wins.js

1 participant