Skip to content

Conversation

@t-will-gillis
Copy link
Member

@t-will-gillis t-will-gillis commented Aug 31, 2025

Fixes #8309

What changes did you make?

  • In activity-trigger.yml, changed trigger to pull_request_target
  • Same file, added default permissions
  • In post-to-skills-issue.js, increased the default per_page from 30 to 100

Why did you make the changes (we will use this info to test)?

  • pull_request trigger does not run against current code and causes an error
  • These permissions are explicitly defining the workflow permissions
  • Sometimes the bot comment will be greater than 30 deep. 100 is the maximum without going to pagination, but this should be adequate.
  • Added the explicit semicolon for the dependabot.

Note that because this PR affects the workflow itself, the workflow will not be triggered.

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

  • No visual changes

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b t-will-gillis-bug-fix-member-activity-8309 gh-pages
git pull https://github.com/t-will-gillis/website.git bug-fix-member-activity-8309

@github-actions github-actions bot added Bug Something isn't working role: back end/devOps Tasks for back-end developers time sensitive Needs to be worked on by a particular timeframe Feature: Onboarding/Contributing.md Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 0.25pt Can be done in 0.5 to 1.5 hours labels Aug 31, 2025
@t-will-gillis t-will-gillis changed the title bug fix --> pull_request_target, per_page incr., exp semicolon Bug fix for "Member Activity Trigger" using pull_request_target Aug 31, 2025
@t-will-gillis
Copy link
Member Author

Merging this immediately because otherwise the workflow will be missing events until merged.

@t-will-gillis t-will-gillis merged commit 88c23cb into hackforla:gh-pages Aug 31, 2025
13 checks passed
@t-will-gillis t-will-gillis deleted the bug-fix-member-activity-8309 branch August 31, 2025 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Onboarding/Contributing.md role: back end/devOps Tasks for back-end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe

Projects

Development

Successfully merging this pull request may close these issues.

Bug fix for "Member Activity Trigger" for PRs/Issues

1 participant