-
-
Notifications
You must be signed in to change notification settings - Fork 843
Update Project Profile Civic-Tech #8315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Project Profile Civic-Tech #8315
Conversation
…uct Manager roles
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Hey @devxed43 FYI you will want to be careful adding reviewers to your PR unless you are re-requesting a previous review, or you have already asked the person. In your case, the two people you requested are both inactive so they won't be able to review your PR. Then active members might skip your PR because they think you already have two reviewers, and no one will review it. |
Thank you @t-will-gillis! the two inactive users that I requested popped up under the reviewers suggestions section in the upper right. I took the liberty to request two users who reviewed my last PR. myronchen and santi-jose |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Edward. Thank you for working on this issue.
Done correctly
- The merge from and to branches are correct.
- The originating issue has been correctly linked.
- This pull request's title is written correctly.
- In the originating issue, you've correctly assigned yourself and posted your ETA. Although for availability, it's supposed to be from what time to what time you are available to be contacted.
- In the originating issue, the project and its status has been correctly assigned.
Changes that need to be made
- Please check off the appropriate CodeQL response in your pull request.
- There is a new commit in
hackforla'sgh-pagesthat causes a merge conflict with your commit. Please update your branch and solve the merge conflict. Also change your screenshots.
Optional recommendations
- In the "changes made" part of your pull request description, you can be more specific by stating that Snigdha Tiwari was added instead of user.
- Your commit title, "I added user Snigdha Tiwari to the civic tech jobs md file after Product Manager roles" is too long. This is the message you have written in VSCode when you committed your changes. I don't believe Hack for LA has a length requirement, but in practice, it is usually at most 50 characters long.
myronchen-git
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is still a merge conflict. Did you follow the instructions on
2.7.e Working on an issue (5): Incorporating changes from upstream,
especially
i. Incorporating changes into your topic branch?
Then did you update your local update-add-user-8110 branch and push it again to your remote repository?
For the "changes made" part of your pull request description, normally only changes that other developers can see would be put here. The new text,
Conflict in main and feature branch arose
Resolved issue by removing Kanika, Snigdha & Jimmy
Result: Identical visual match to hackforla site
wouldn't normally be put here, but instead in an extra comment to your pull request. Since this is your second issue that you are working on, you can leave it as is.
myronchen-git
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes that need to be made
- When you solved your merge conflict, you accidentally also deleted the changes you needed to make. At the top of this pull request, in the Files changed tab, it shows that Snigdha Tiwari has not been added.
- Your screenshots are also incorrect. Your "before changes" screenshot should not have Kanika, Snigdha, nor Jimmy. Your "after changes" screenshot should have Snigdha.
myronchen-git
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Edward. Thank you for making the corrections.
Done correctly
- Screenshots are correct.
- Contains the correct code changes.
Changes that need to be made
Your pull request description's "changes made" part does not explain enough about what changed. Please look at the example in the instructions for completing a pull request.
myronchen-git
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All mistakes have been corrected.
|
Review ETA: 8 PM 9/12/2025 |
santi-jose
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Edward, good work on this PR.
Things done well:
- Into and from branches are correct
- Issue is linked in correct format
- CodeQL Alerts have been properly checked
- Pull Request states what changes in the website
- Pull Request states why changes are made in the website
- Pictures are included to show the visual effects of the changes before and after the updates
- Proper changes made in code
- Changes in code don't break website
Overall great work!
Fixes #8110
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied