Skip to content

Conversation

@devxed43
Copy link
Member

@devxed43 devxed43 commented Sep 1, 2025

Fixes #8110

What changes did you make?

  • Added Snigdha Tiwari to Civic Tech Jobs md file

Why did you make the changes (we will use this info to test)?

  • To keep civic tech jobs projects profile up-to-date

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied before
Visuals after changes are applied after

@github-actions
Copy link

github-actions bot commented Sep 1, 2025

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b devxed43-update-add-user-8110 gh-pages
git pull https://github.com/devxed43/website.git update-add-user-8110

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Sep 1, 2025
@t-will-gillis
Copy link
Member

Hey @devxed43 FYI you will want to be careful adding reviewers to your PR unless you are re-requesting a previous review, or you have already asked the person. In your case, the two people you requested are both inactive so they won't be able to review your PR. Then active members might skip your PR because they think you already have two reviewers, and no one will review it.

@devxed43
Copy link
Member Author

devxed43 commented Sep 6, 2025

Hey @devxed43 FYI you will want to be careful adding reviewers to your PR unless you are re-requesting a previous review, or you have already asked the person. In your case, the two people you requested are both inactive so they won't be able to review your PR. Then active members might skip your PR because they think you already have two reviewers, and no one will review it.

Thank you @t-will-gillis! the two inactive users that I requested popped up under the reviewers suggestions section in the upper right. I took the liberty to request two users who reviewed my last PR. myronchen and santi-jose

Copy link
Member

@myronchen-git myronchen-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Edward. Thank you for working on this issue.


Done correctly

  • The merge from and to branches are correct.
  • The originating issue has been correctly linked.
  • This pull request's title is written correctly.
  • In the originating issue, you've correctly assigned yourself and posted your ETA. Although for availability, it's supposed to be from what time to what time you are available to be contacted.
  • In the originating issue, the project and its status has been correctly assigned.

Changes that need to be made

  • Please check off the appropriate CodeQL response in your pull request.
  • There is a new commit in hackforla's gh-pages that causes a merge conflict with your commit. Please update your branch and solve the merge conflict. Also change your screenshots.

Optional recommendations

  • In the "changes made" part of your pull request description, you can be more specific by stating that Snigdha Tiwari was added instead of user.
  • Your commit title, "I added user Snigdha Tiwari to the civic tech jobs md file after Product Manager roles" is too long. This is the message you have written in VSCode when you committed your changes. I don't believe Hack for LA has a length requirement, but in practice, it is usually at most 50 characters long.

@github-project-automation github-project-automation bot moved this from PR Needs review to PRs being reviewed in P: HfLA Website: Project Board Sep 6, 2025
Copy link
Member

@myronchen-git myronchen-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still a merge conflict. Did you follow the instructions on
2.7.e Working on an issue (5): Incorporating changes from upstream,
especially
i. Incorporating changes into your topic branch?
Then did you update your local update-add-user-8110 branch and push it again to your remote repository?


For the "changes made" part of your pull request description, normally only changes that other developers can see would be put here. The new text,

Conflict in main and feature branch arose
Resolved issue by removing Kanika, Snigdha & Jimmy
Result: Identical visual match to hackforla site

wouldn't normally be put here, but instead in an extra comment to your pull request. Since this is your second issue that you are working on, you can leave it as is.

Copy link
Member

@myronchen-git myronchen-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes that need to be made

  • When you solved your merge conflict, you accidentally also deleted the changes you needed to make. At the top of this pull request, in the Files changed tab, it shows that Snigdha Tiwari has not been added.
  • Your screenshots are also incorrect. Your "before changes" screenshot should not have Kanika, Snigdha, nor Jimmy. Your "after changes" screenshot should have Snigdha.

myronchen-git

This comment was marked as outdated.

@myronchen-git myronchen-git self-requested a review September 10, 2025 17:45
Copy link
Member

@myronchen-git myronchen-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Edward. Thank you for making the corrections.


Done correctly

  • Screenshots are correct.
  • Contains the correct code changes.

Changes that need to be made

Your pull request description's "changes made" part does not explain enough about what changed. Please look at the example in the instructions for completing a pull request.

Copy link
Member

@myronchen-git myronchen-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All mistakes have been corrected.

@santi-jose
Copy link
Member

Review ETA: 8 PM 9/12/2025
Availability: 5-7 PM Monday - Thursday

Copy link
Member

@santi-jose santi-jose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Edward, good work on this PR.

Things done well:

  1. Into and from branches are correct
  2. Issue is linked in correct format
  3. CodeQL Alerts have been properly checked
  4. Pull Request states what changes in the website
  5. Pull Request states why changes are made in the website
  6. Pictures are included to show the visual effects of the changes before and after the updates
  7. Proper changes made in code
  8. Changes in code don't break website

Overall great work!

@github-project-automation github-project-automation bot moved this from PRs being reviewed to PRs ✅ waiting for merge team in P: HfLA Website: Project Board Sep 12, 2025
@t-will-gillis t-will-gillis merged commit a934fc3 into hackforla:gh-pages Sep 14, 2025
7 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe

Projects

Development

Successfully merging this pull request may close these issues.

Update Project Profile: Civic Tech Jobs - Add Snigdha Tiwari

4 participants