added github-handle variable for Bonnie in _projects/vrms.md#8386
added github-handle variable for Bonnie in _projects/vrms.md#8386ryanfkeller merged 4 commits intohackforla:gh-pagesfrom
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Review ETA: 6 PM 10/29/25 |
|
Thank you for working on this issue, @cadenramey! Done Correctly:
Changes Required:
Thank you for contributing! |
Mykola-Lopushenko
left a comment
There was a problem hiding this comment.
Thank you for your work on this PR!
Changes Required:
- The issue specifies using the variable name
github-handle, but the PR usesgit-handle.
Please rename it togithub-handlefor consistency with the project. - The PR title should also reflect the correct variable name.
Once updated, I’ll re-review. Thanks!
|
Just updated and had a merge conflict which fairly certain I resolved correctly? I'm not sure because now there are 5 changed files which I think are just others' issues that have gotten merged onto the project since my initial commit. I had to update my branch before I pushed my new change but if anything looks weird please let me know! |
Mykola-Lopushenko
left a comment
There was a problem hiding this comment.
Thank you for the update!
It looks like your branch now contains additional changes from other merged PRs. For this issue, the only file that should be modified is: _projects/vrms.md
The other changed files appear unrelated to this issue, so they need to be removed from this PR.
6c8659d to
e538733
Compare
ryanfkeller
left a comment
There was a problem hiding this comment.
Hi @cadenramey,
Nice job on this PR and resolving the merge conflicts that came up! Your changes look good, your PR description is solid, and you're targeting the correct branch. Approved, nice work.
Fixes #7352
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)