Skip to content

added github-handle variable for Bonnie in _projects/vrms.md#8386

Merged
ryanfkeller merged 4 commits intohackforla:gh-pagesfrom
cadenramey:add-git-handle-bonnie-7352
Oct 29, 2025
Merged

added github-handle variable for Bonnie in _projects/vrms.md#8386
ryanfkeller merged 4 commits intohackforla:gh-pagesfrom
cadenramey:add-git-handle-bonnie-7352

Conversation

@cadenramey
Copy link
Member

@cadenramey cadenramey commented Oct 26, 2025

Fixes #7352

What changes did you make?

  • Added github-handle variable under Bonnie's name in _projects/vrms.md

Why did you make the changes (we will use this info to test)?

  • Added github-handle variable to eventually replace github and picture variables to make code more succinct.

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

  • No visual changes to website

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b cadenramey-add-git-handle-bonnie-7352 gh-pages
git pull https://github.com/cadenramey/website.git add-git-handle-bonnie-7352

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Oct 26, 2025
@cadenramey cadenramey added the status: Updated No blockers and update is ready for review label Oct 26, 2025
@github-actions github-actions bot removed the status: Updated No blockers and update is ready for review label Oct 26, 2025
@Mykola-Lopushenko Mykola-Lopushenko self-requested a review October 29, 2025 00:11
@Mykola-Lopushenko
Copy link
Member

Review ETA: 6 PM 10/29/25
Availability: 6-8 PM Monday-Friday

@Mykola-Lopushenko
Copy link
Member

Thank you for working on this issue, @cadenramey!

Done Correctly:

  • The merge from and to branches have been correctly set.
  • The issue has been correctly linked.
  • In the issue, you've correctly assigned yourself.

Changes Required:

  • The issue requires adding the variable named github-handle, but the PR uses git-handle.
    Please rename it to github-handle to match the required format and future usage across the project.
  • The PR title should also reflect the correct variable name.
    Once you update the variable in the file, please update the PR title as well.

Thank you for contributing!

Copy link
Member

@Mykola-Lopushenko Mykola-Lopushenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work on this PR!

Changes Required:

  • The issue specifies using the variable name github-handle, but the PR uses git-handle.
    Please rename it to github-handle for consistency with the project.
  • The PR title should also reflect the correct variable name.

Once updated, I’ll re-review. Thanks!

@github-project-automation github-project-automation bot moved this from PR Needs review to PRs being reviewed in P: HfLA Website: Project Board Oct 29, 2025
@cadenramey cadenramey changed the title added git-handle variable for Bonnie in _projects/vrms.md added github-handle variable for Bonnie in _projects/vrms.md Oct 29, 2025
@cadenramey
Copy link
Member Author

cadenramey commented Oct 29, 2025

Just updated and had a merge conflict which fairly certain I resolved correctly? I'm not sure because now there are 5 changed files which I think are just others' issues that have gotten merged onto the project since my initial commit. I had to update my branch before I pushed my new change but if anything looks weird please let me know!

Copy link
Member

@Mykola-Lopushenko Mykola-Lopushenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update!

It looks like your branch now contains additional changes from other merged PRs. For this issue, the only file that should be modified is: _projects/vrms.md

The other changed files appear unrelated to this issue, so they need to be removed from this PR.

@DDVVPP DDVVPP requested a review from ryanfkeller October 29, 2025 02:09
@cadenramey cadenramey force-pushed the add-git-handle-bonnie-7352 branch from 6c8659d to e538733 Compare October 29, 2025 02:24
Copy link
Member

@Mykola-Lopushenko Mykola-Lopushenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

Copy link
Member

@ryanfkeller ryanfkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cadenramey,

Nice job on this PR and resolving the merge conflicts that came up! Your changes look good, your PR description is solid, and you're targeting the correct branch. Approved, nice work.

@github-project-automation github-project-automation bot moved this from PRs being reviewed to PRs ✅ waiting for merge team in P: HfLA Website: Project Board Oct 29, 2025
@ryanfkeller ryanfkeller merged commit b4c8e6a into hackforla:gh-pages Oct 29, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

Development

Successfully merging this pull request may close these issues.

Add github-handle for Bonnie Wolfe in vrms.md

3 participants