Add Ryan Keller to Website Project pg#8505
Add Ryan Keller to Website Project pg#8505mocodesss wants to merge 1 commit intohackforla:gh-pagesfrom
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Hi @mocodesss! Thanks for working on this issue. I had to ask a team lead about the two QL Code alerts, but it's an easy fix if you have a sec. Your two checks aren't passing because you wrote: "Fixes https://..." instead of "Fixes # https://..." So you need to edit your PR by typing "Fixes #" + (no space) + "8398" and the two checks will pass. Thx in advance for wrapping this up! |
|
Hi @kdaca19xx ! I updated the ticket with that "Fixes #8398" and the checks passed. Thank you so much for the help there! |
abinetabate1
left a comment
There was a problem hiding this comment.
Looks good. Thank you!
Please make sure to check the checkbox for CodeQL alerts.
|
Availability: 2/11 4:30p - 7:30p |
Fixes #8398
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied