abc notation requirement update #1891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackycute
reviewed
Apr 18, 2025
public/views/codimd/foot.ejs
Outdated
| <script src="https://cdnjs.cloudflare.com/ajax/libs/viz.js/2.1.2/full.render.js" integrity="sha256-Ogqs510LFnekr9o7OLdpelaaAmNss9egQRTyzCqV2NQ=" crossorigin="anonymous" defer></script> | ||
| <script src="https://cdnjs.cloudflare.com/ajax/libs/abcjs/3.1.1/abcjs_basic-min.js" integrity="sha256-Sq1r2XXWXQoShQKsS0Wrf5r7fRkErd9Fat9vHYeU68s=" crossorigin="anonymous" defer></script> | ||
| <script src="https://cdnjs.cloudflare.com/ajax/libs/abcjs/6.2.3/abcjs_basic-min.js" integrity="sha256-Sq1r2XXWXQoShQKsS0Wrf5r7fRkErd9Fat9vHYeU68s=" crossorigin="anonymous" defer></script> |
Member
There was a problem hiding this comment.
The integrity need to be updated as well.
Member
|
Hi @Matt-V50, |
Update foot.ejs abc notation requirement update the bass fingering will conflict with each other if there is more than one fingering annotation. example ```abc `X:1 T:Simple Scale M:4/4 L:1/4 K:C "_1" "_2" C D E F|G A B c|]` ``` Signed-off-by: Matt Li <[email protected]>
Signed-off-by: Matt Li <[email protected]>
Contributor
Author
|
@jackycute Done |
jackycute
approved these changes
May 15, 2025
Yukaii
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update foot.ejs
abc notation requirement update
the bass fingering will conflict with each other if there is more than one fingering annotation.
example