Skip to content

Refactor plugin paths and move custom reveal plugin #1898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Yukaii merged 3 commits into from
May 15, 2025
Merged

Refactor plugin paths and move custom reveal plugin #1898

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
72df04d
refactor: move custom reveal plugin to public/js
Yukaii Mar 20, 2025
ad24c09
fix: update plugin paths for spotlight and elapsed-time-bar in slide.js
Yukaii Mar 20, 2025
9f0e3a7
fix: add eslint-disable comments to elapsed-time-bar and spotlight pl…
Yukaii Mar 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...ugin/elapsed-time-bar/elapsed-time-bar.js → ...gins/elapsed-time-bar/elapsed-time-bar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable */
Copy link

Copilot AI Apr 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider disabling only targeted ESLint rules instead of using a blanket disable to maintain better code quality.

Suggested change
/* eslint-disable */
/* eslint-disable no-var, prefer-arrow-callback, no-unused-vars */

Copilot uses AI. Check for mistakes.
var ElapsedTimeBar = {
// default value
barColor: 'rgb(200,0,0)',
Expand Down
1 change: 1 addition & 0 deletions ...d/reveal.js/plugin/spotlight/spotlight.js → ...s/revealjs-plugins/spotlight/spotlight.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable */
Copy link

Copilot AI Apr 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Using a blanket 'eslint-disable' can hide potential issues; consider disabling only the specific ESLint rules that require suppression.

Suggested change
/* eslint-disable */
/* eslint-disable no-var, no-unused-vars */

Copilot uses AI. Check for mistakes.
var RevealSpotlight = window.RevealSpotlight || (function () {

//configs
Expand Down
4 changes: 2 additions & 2 deletions public/js/slide.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,13 +85,13 @@ delete options.dependencies

if (Object.hasOwnProperty.call(options, 'spotlight')) {
defaultOptions.dependencies.push({
src: `${serverurl}/build/reveal.js/plugin/spotlight/spotlight.js`
src: `${serverurl}/build/revealjs-plugins/spotlight/spotlight.js`
})
}

if (Object.hasOwnProperty.call(options, 'allottedTime') || Object.hasOwnProperty.call(options, 'allottedMinutes')) {
defaultOptions.dependencies.push({
src: `${serverurl}/build/reveal.js/plugin/elapsed-time-bar/elapsed-time-bar.js`
src: `${serverurl}/build/revealjs-plugins/elapsed-time-bar/elapsed-time-bar.js`
})
if (Object.hasOwnProperty.call(options, 'allottedMinutes')) {
options.allottedTime = options.allottedMinutes * 60 * 1000
Expand Down
5 changes: 5 additions & 0 deletions webpack.common.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,11 @@ module.exports = {
from: 'plugin',
to: 'reveal.js/plugin'
},
{
context: path.join(__dirname, 'public/js'),
from: 'revealjs-plugins',
to: 'revealjs-plugins'
},
{
context: path.join(__dirname, 'node_modules/dictionary-de'),
from: '*',
Expand Down