Skip to content

fix/client resync mechanism & quality-of-life improvements #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

fix/client resync mechanism & quality-of-life improvements #29

wants to merge 9 commits into from

Conversation

stanley2058
Copy link
Collaborator

This PR includes:

  • Client would now try to resync whenever it detects an update is not being ack-ed from the server for over 3s
    • Side note: double-submitting is not an issue, yjs ignores duplicated updates.
  • Allow supplying a full socket instance to the client provider
    • This allows patching methods for testing; one MUST make sure the connection string is correct, since it's different from the one passed to the provider.
  • Fix tsup broken due to incorrect Redis import
  • Silent Redis client closed error (improve SNR in automated testing)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@stanley2058