Open
Conversation
Member
|
This will need upstream changes merged in/resolved prior to approval. As not on Windows, would want someone with windows to review |
Contributor
Author
|
That would most likely be @code-farmhouse for the other Windows reviewer. What's with the Travis fails though? |
Member
|
Merge in current staging branch to this, I think you branched off prior to some fixes/changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix the line endings issues. I got it to run on my Windows 10 Pro / Docker for Windows laptop. However, it's a bit slow. The laptop has only 8 GB of RAM of which the Docker host VM only has 2 GB to work in.
If you have more RAM, check your Docker settings to see if you can give the Docker VM more RAM. Even so, it will take some time to come up; the database restore is very disk-intensive and it's being done in a VM!