fail build even if violation context was provided

hadarshjfrog · hadarshjfrog · commit 1a4f7e989025 · 2025-03-31T23:40:13.000+03:00
diff --git a/commands/scan/scan.go b/commands/scan/scan.go
@@ -269,8 +269,9 @@ func (scanCmd *ScanCommand) RunAndRecordResults(cmdType utils.CommandType, recor
 	if err = cmdResults.GetErrors(); err != nil {
 		return
 	}
+	// If violation context was proivded it means that context was provided, so we need to check for build violations.
 	// If user provided --fail=false, don't fail the build.
-	if scanCmd.fail {
+	if scanCmd.fail && scanCmd.resultsContext.HasViolationContext() {
 		if results.CheckIfFailBuild(cmdResults.GetScaScansXrayResults()) {
 			return results.NewFailBuildError()
 		}

Original file line number	Diff line number	Diff line change
`@@ -269,8 +269,9 @@ func (scanCmd *ScanCommand) RunAndRecordResults(cmdType utils.CommandType, recor`
`269`	`269`	`if err = cmdResults.GetErrors(); err != nil {`
`270`	`270`	`return`
`271`	`271`	`}`
	`272`	`+ // If violation context was proivded it means that context was provided, so we need to check for build violations.`
`272`	`273`	`// If user provided --fail=false, don't fail the build.`
`273`		`- if scanCmd.fail {`
	`274`	`+ if scanCmd.fail && scanCmd.resultsContext.HasViolationContext() {`
`274`	`275`	`if results.CheckIfFailBuild(cmdResults.GetScaScansXrayResults()) {`
`275`	`276`	`return results.NewFailBuildError()`
`276`	`277`	`}`