Feat: Setting to allow disabling stemming#36
Open
HEmile wants to merge 7 commits intohadynz:masterfrom
Open
Conversation
Also fixes plugin not reloading the indexer on changing settings.
Author
|
Couple more features added:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported in #25, I had many false positives. This PR adds a setting which allows disabling the stemming feature. In my quick tests, all results I get are now true positives (that is, exact matches with something in the tags, page names and aliases).
Of course, this will not be as flexible because it will not use the automatic stemming algorithm, but I greatly prefer some false negatives above many false positives here.
This PR fixes a crash when no matching tokens can be found in
mapStemToOriginalText, disabling the entire plugins functionality. Could be related to #32 and #33.