Efficient frame coalescing and ack for viewer delivery #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract shared test fixtures and mocks from RemoteViewer.IntegrationTests into a new RemoteViewer.TestFixtures project. Update namespaces and using directives accordingly. Add RemoteViewer.TestFixtures.csproj with necessary dependencies and project references. Update test projects to reference the new shared fixture project, improving reusability and maintainability.
Introduce ClientSendGrain to queue and coalesce screen frames per viewer, ensuring only the latest frame is delivered after explicit client ack. Update client/server protocol to support frame acknowledgments. Add integration tests for coalescing logic. Improve logging and refactor message delivery for reliability and backpressure.
haefele
force-pushed
the
dah/frame_dropping
branch
from
c091ef4 to
63ad51b
Compare
Add connectionId parameter to AckFrame to support per-connection frame tracking, allowing multiple viewer connections to have independent frame buffers. Fix synchronization issue in FrameSendState where Interlocked.Exchange was used on nullable structs (QueuedMessage?) which doesn't work correctly in .NET. Replaced with proper lock-based approach that atomically manages both _inFlight and _pendingFrame state. Co-Authored-By: Claude Opus 4.5 <[email protected]>
haefele
force-pushed
the
dah/frame_dropping
branch
from
2d6721b to
18733c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.