Open
Conversation
ehigham
force-pushed
the
ehigham/modularise
branch
4 times, most recently
from
2f555df to
ef6a9e9
Compare
ehigham
force-pushed
the
ehigham/modularise
branch
12 times, most recently
from
2d882f0 to
2299789
Compare
patrick-schultz
requested changes
Jan 21, 2026
Member
patrick-schultz
left a comment
patrick-schultz
left a comment
There was a problem hiding this comment.
Great change. Thanks for keeping it strictly moving code. I only saw one minor nit while scanning it over.
ehigham
force-pushed
the
ehigham/modularise
branch
2 times, most recently
from
373ad79 to
4e305f2
Compare
ehigham
force-pushed
the
ehigham/modularise
branch
from
4e305f2 to
5a3d631
Compare
ehigham
force-pushed
the
ehigham/modularise
branch
2 times, most recently
from
ccf3923 to
57fef9a
Compare
patrick-schultz
approved these changes
Feb 3, 2026
ehigham
force-pushed
the
ehigham/modularise
branch
2 times, most recently
from
dc86cf2 to
e3a8167
Compare
chrisvittal
approved these changes
Feb 5, 2026
ehigham
force-pushed
the
ehigham/modularise
branch
from
e3a8167 to
30bac59
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fun change...
Starts the process of modularising the scala code by extracting "utils" into its own module.
Some utility classes have been moved into the
is.hail.collectionpackage, mirroring scala's stdlib. Most of the noise in this PR comes from changes to imports.There are no functional changes herein, only moves and deletes of unused code.
For now, the tests remain in the root hail module. I need to think how to move the utils tests into the new module without breaking CI.
Dependency declaration and duplication to be handled in a subsequent change.
This change has no impact on the Broad-managed hail batch deployment in GCP