[query] Cache Alpha-Equivalent Compiled Functions#15262
Open
ehigham wants to merge 1 commit intohail-is:mainfrom
Open
[query] Cache Alpha-Equivalent Compiled Functions#15262ehigham wants to merge 1 commit intohail-is:mainfrom
ehigham wants to merge 1 commit intohail-is:mainfrom
Conversation
9f8296a to
70904b0
Compare
ehigham
commented
Feb 5, 2026
Comment on lines
-111
to
-115
| /* { def visit(x: IR): Unit = { println(f"${ System.identityHashCode(x) }%08x ${ | ||
| * x.getClass.getSimpleName } ${ x.pType }") Children(x).foreach { case c: IR => visit(c) | ||
| * } } | ||
| * | ||
| * visit(ir) } */ |
86bbd37 to
21a7443
Compare
21a7443 to
86dce50
Compare
chrisvittal
approved these changes
Feb 5, 2026
Comment on lines
-111
to
-115
| /* { def visit(x: IR): Unit = { println(f"${ System.identityHashCode(x) }%08x ${ | ||
| * x.getClass.getSimpleName } ${ x.pType }") Children(x).foreach { case c: IR => visit(c) | ||
| * } } | ||
| * | ||
| * visit(ir) } */ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid using names in the compiled function cache so that alpha-equivalent IRs share a cache entry.
Compile requires the ir argument is
Compilable. This is already enforced by thecompileLowerer.This change has no impact on the broad-managed batch service in gcp.