fix: preserve comments and blank lines when removing unused imports#316
Closed
hakancelikdev wants to merge 2 commits intomainfrom
Closed
fix: preserve comments and blank lines when removing unused imports#316hakancelikdev wants to merge 2 commits intomainfrom
hakancelikdev wants to merge 2 commits intomainfrom
Conversation
When removing an unused import, libcst's RemoveFromParent() also removed comment lines and blank lines above the import. This change uses a two-phase approach: mark imports for removal, then in leave_SimpleStatementLine extract comment-bearing leading lines and transfer them to the next sibling statement. A stack-based push/pop mechanism isolates pending lines across compound statement boundaries (class, function, if, for, etc.) so nested statements don't consume comments from the outer scope. Closes #100 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
hakancelikdev
force-pushed
the
fix/preserve-comments-on-import-removal
branch
from
e11b145 to
936dec2
Compare
Remove codecov integration, pytest-cov dependency, and coverage CI job as they are no longer needed. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When removing an unused import, libcst's RemoveFromParent() also removed comment lines and blank lines above the import. This change uses a two-phase approach: mark imports for removal, then in leave_SimpleStatementLine extract comment-bearing leading lines and transfer them to the next sibling statement.
A stack-based push/pop mechanism isolates pending lines across compound statement boundaries (class, function, if, for, etc.) so nested statements don't consume comments from the outer scope.
Closes #100