Fix import after use in function incorrectly removed (#178) #178#321
Merged
hakancelikdev merged 1 commit intomainfrom Feb 18, 2026
Merged
Fix import after use in function incorrectly removed (#178) #178#321hakancelikdev merged 1 commit intomainfrom
hakancelikdev merged 1 commit intomainfrom
Conversation
When a module-level import appears textually after a function that uses it, unimport incorrectly removed it. Function/async function bodies are deferred (only execute when called), so imports defined later at module scope are available at call time. Class bodies execute immediately, so the lineno check still applies for them. Added Name._is_deferred_usage() that walks from the Name's scope toward the Import's scope — if any scope on the path is a FunctionDef or AsyncFunctionDef, the usage is deferred and the lineno check is relaxed. Edge case tests cover: async functions, nested functions, class bodies (not deferred), methods inside classes, from-imports, and module-level sequential usage. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a module-level import appears textually after a function that uses it, unimport incorrectly removed it. Function/async function bodies are deferred (only execute when called), so imports defined later at module scope are available at call time. Class bodies execute immediately, so the lineno check still applies for them.
Added Name._is_deferred_usage() that walks from the Name's scope toward the Import's scope — if any scope on the path is a FunctionDef or AsyncFunctionDef, the usage is deferred and the lineno check is relaxed.
Edge case tests cover: async functions, nested functions, class bodies (not deferred), methods inside classes, from-imports, and module-level sequential usage.