Skip to content

Improve webpack config #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fabon-f wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Improve webpack config #333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
efc2e77
Remove unnecessary babel plugins
fabon-f May 31, 2023
3b27a08
Target only modern browsers in webpack config
fabon-f May 31, 2023
eadbffa
Stop generating source map on production mode
fabon-f May 31, 2023
f4afe0a
Update babel config about polyfill
fabon-f May 31, 2023
1cada63
Update browserslist
fabon-f May 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
203 changes: 63 additions & 140 deletions package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 1 addition & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,6 @@
},
"dependencies": {
"@babel/core": "^7.22.1",
"@babel/plugin-proposal-class-properties": "^7.18.6",
"@babel/plugin-proposal-object-rest-spread": "^7.20.7",
"@babel/polyfill": "^7.8.7",
"@babel/preset-env": "^7.22.4",
"@babel/preset-react": "^7.22.3",
"@slack/web-api": "^6.8.1",
Expand All @@ -35,6 +32,7 @@
"compression": "^1.7.4",
"concat-stream": "^2.0.0",
"connect-mongo": "^5.0.0",
"core-js": "^3.30.2",
"discord.js": "^14.11.0",
"dockerode": "^3.3.5",
"dotenv": "^16.1.0",
Expand Down
2 changes: 1 addition & 1 deletion public/js/check.babel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import '@babel/polyfill';
import 'core-js/stable';

import api from './api.js';

Expand Down
2 changes: 1 addition & 1 deletion public/js/contests/4/index.babel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import '@babel/polyfill';
import 'core-js/stable';

import React from 'react';
import ReactDOM from 'react-dom';
Expand Down
2 changes: 1 addition & 1 deletion public/js/contests/5/index.babel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import '@babel/polyfill';
import 'core-js/stable';

import React from 'react';
import ReactDOM from 'react-dom';
Expand Down
2 changes: 1 addition & 1 deletion public/js/contests/6/index.babel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import '@babel/polyfill';
import 'core-js/stable';

import React from 'react';
import ReactDOM from 'react-dom';
Expand Down
2 changes: 1 addition & 1 deletion public/js/contests/hackathon2018/index.babel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import '@babel/polyfill';
import 'core-js/stable';

import React from 'react';
import ReactDOM from 'react-dom';
Expand Down
2 changes: 1 addition & 1 deletion public/js/contests/mayfes2018/index.babel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import '@babel/polyfill';
import 'core-js/stable';

import React from 'react';
import ReactDOM from 'react-dom';
Expand Down
2 changes: 1 addition & 1 deletion public/js/contests/mayfes2020-day2/index.babel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import '@babel/polyfill';
import 'core-js/stable';

import React from 'react';
import ReactDOM from 'react-dom';
Expand Down
2 changes: 1 addition & 1 deletion public/js/contests/mayfes2021-day2/index.babel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import '@babel/polyfill';
import 'core-js/stable';

import React from 'react';
import ReactDOM from 'react-dom';
Expand Down
9 changes: 3 additions & 6 deletions webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ module.exports = (env, argv = {}) => {
const browsers = [
'last 2 chrome versions',
...(argv.mode === 'production'
? ['last 2 firefox versions', 'safari >= 9', 'last 2 edge versions']
? ['last 2 firefox versions', 'last 3 safari versions', 'last 2 edge versions']
: []),
];

Expand All @@ -14,6 +14,7 @@ module.exports = (env, argv = {}) => {
browsers,
},
useBuiltIns: 'entry',
corejs: require('core-js/package.json').version,
Copy link
Owner

@hakatashi hakatashi May 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[SHOULD] Move all requires to the top.

shippedProposals: true,
debug: true,
};
Expand Down Expand Up @@ -52,7 +53,7 @@ module.exports = (env, argv = {}) => {
},
devtool:
argv.mode === 'production'
? 'source-map'
? false
: 'eval-cheap-module-source-map',
module: {
rules: [
Expand All @@ -66,10 +67,6 @@ module.exports = (env, argv = {}) => {
['@babel/preset-env', envConfig],
'@babel/preset-react',
],
plugins: [
'@babel/plugin-proposal-class-properties',
'@babel/plugin-proposal-object-rest-spread',
],
},
},
},
Expand Down