Skip to content

Add configurable sizing to Iconify input#8346

Merged
f2c-ci-robot[bot] merged 2 commits intohalo-dev:mainfrom
ruibaby:feat/iconify-sizing
Feb 14, 2026
Merged

Add configurable sizing to Iconify input#8346
f2c-ci-robot[bot] merged 2 commits intohalo-dev:mainfrom
ruibaby:feat/iconify-sizing

Conversation

@ruibaby
Copy link
Member

@ruibaby ruibaby commented Feb 11, 2026

What type of PR is this?

/area ui
/kind feature
/milestone 2.23.x

What this PR does / why we need it:

Add configurable sizing to Iconify input, example:

- $formkit: iconify
  sizing:
    enabled: true # default false
    default: '24px'
    presets:
      - 24px
      - 32px
      - 64px

Which issue(s) this PR fixes:

Fixes #8046

Does this PR introduce a user-facing change?

FormKit Iconify 支持设置尺寸参数,默认不再向用户显示尺寸设置选项

@f2c-ci-robot f2c-ci-robot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Feb 11, 2026
@f2c-ci-robot f2c-ci-robot bot added this to the 2.23.x milestone Feb 11, 2026
@f2c-ci-robot f2c-ci-robot bot added area/ui Issues or PRs related to the Halo UI kind/feature Categorizes issue or PR as related to a new feature. labels Feb 11, 2026
@codecov
Copy link

codecov bot commented Feb 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.83%. Comparing base (42c374d) to head (2ac3eb4).
⚠️ Report is 454 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #8346      +/-   ##
============================================
+ Coverage     59.55%   60.83%   +1.27%     
- Complexity     3812     3999     +187     
============================================
  Files           677      698      +21     
  Lines         23248    23856     +608     
  Branches       1500     1555      +55     
============================================
+ Hits          13846    14513     +667     
+ Misses         8764     8613     -151     
- Partials        638      730      +92     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Delete a stray '{{ sizing }}' interpolation from the IconifyInput.vue template to prevent raw text from rendering in the UI. This is a minor cleanup with no functional changes to the component.
@sonarqubecloud
Copy link

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2026
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Feb 14, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2026
@f2c-ci-robot f2c-ci-robot bot merged commit 281e699 into halo-dev:main Feb 14, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

希望对iconify组件增加,大小下拉选配置以及默认选择的大小配置项

2 participants