Skip to content

Fix page jitter by compensating for scrollbar width #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
f2c-ci-robot merged 5 commits into from
Nov 20, 2025
Merged

Fix page jitter by compensating for scrollbar width #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
29b5230
Initial plan
Copilot Nov 19, 2025
fa95137
Add lockScroll option to control scrollbar hiding behavior
Copilot Nov 19, 2025
d43f844
Update documentation to describe lockScroll option
Copilot Nov 19, 2025
93befea
Changes before error encountered
Copilot Nov 19, 2025
1cadad6
Fix page jitter by compensating for scrollbar width
Copilot Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions packages/search-widget/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,22 @@
</style>
</head>
<body>
<button>启动</button>
<button id="color">暗色/亮色</button>
<h1>Search Widget - Page Jitter Fix Test</h1>
<button>Open Search Modal</button>
<button id="color">Toggle Dark/Light Mode</button>

<div style="margin-top: 2rem;">
<h2>Testing the Fix</h2>
<p>This page has enough content to show a scrollbar. When you open the search modal, the page should NOT shift to the right.</p>
<p>The fix works by calculating the scrollbar width and adding equivalent padding to compensate for the scrollbar removal.</p>
</div>

<!-- Add enough content to ensure scrollbar appears -->
<div style="height: 2000px; background: linear-gradient(to bottom, #f0f0f0, #e0e0e0);">
<p style="padding: 2rem;">Long content to ensure scrollbar is visible...</p>
<p style="padding: 2rem;">Notice that when the modal opens, there's no layout shift!</p>
</div>

<search-modal></search-modal>
</body>
<script>
Expand Down
8 changes: 8 additions & 0 deletions packages/search-widget/src/search-modal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,17 @@ export class SearchModal extends LitElement {
}

if (this.open) {
// Calculate scrollbar width to prevent layout shift
const scrollbarWidth =
window.innerWidth - document.documentElement.clientWidth;
document.body.style.overflow = 'hidden';
// Add padding to compensate for scrollbar removal
if (scrollbarWidth > 0) {
document.body.style.paddingRight = `${scrollbarWidth}px`;
}
} else {
document.body.style.removeProperty('overflow');
document.body.style.removeProperty('padding-right');
}
}

Expand Down