Fix/3989 dreamlands eclipse not working#4142
Open
wdqin wants to merge 2 commits intohalogenandtoast:mainfrom
Open
Fix/3989 dreamlands eclipse not working#4142wdqin wants to merge 2 commits intohalogenandtoast:mainfrom
wdqin wants to merge 2 commits intohalogenandtoast:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title:
Fix Dreamlands Eclipse shroud bonus targeting during Ancient Stone investigations
Issue ID: 3989
Dreamlands Eclipse
#3989
Summary:
This fixes Dreamlands Eclipse so its “Your location gets +2 shroud for this investigation” option applies to the investigated location, rather than the full skill test target.
Problem:
The bug showed up when the investigation target was a ProxyTarget, such as Ancient Stone (Unidentified). In that case, Dreamlands Eclipse was applying ShroudModifier 2 to the proxy target, but the final skill test difficulty is derived from the investigated location’s shroud calculation, so the +2 never affected the displayed or resolved difficulty.
Change:
Implementation references:
This change follows the same location-targeting pattern already used by existing shroud-adjusting implementations:
Files changed:
Test coverage:
Added regression coverage for:
Validation:
Ran:
stack --work-dir .stack-work-dreamlands-test test arkham-api --flag pcre-light:use-pkg-config --ta '--match "Dreamlands Eclipse"'
Result:
2 examples, 0 failures
The test difficulty has correctly changed from 7 to 9.