Webui to show child reports on test completion for all subscribed clients #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes several issues with multislot test display in the web UI:
1. pub_sub.py: Handle send errors gracefully so all clients receive
messages even if one client fails (e.g., due to event loop issues
in child test threads)
2. station_server.py:
- Add phase descriptor caching to persist after test completion
- Detect new child tests when polling and re-poll to include them
- Fix race condition by updating _last_update_message before publish()
- Track 'update' messages separately from 'record' messages for
new subscriber initial state
3. station.service.ts: Don't overwrite stored child tests with empty
array when 'record' messages arrive
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Pull Request Test Coverage Report for Build 21232247966Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For any number of clients subscribed to a test, each will be able to view the test reports of the child tests on the web ui. Previously only 1 client (the earliest subscribing one) was able to view child test results. The others could only view the parent test. This was a huge issue with having visibility on ICT test results in real time.
This was done with Claude.
Works fine with a single parent test, and for multislot tests