Skip to content

Revert "Remove before_commit callback on test"#38

Merged
hamajyotan merged 1 commit intomainfrom
revert-37-remove-before-commit-callback
Oct 12, 2025
Merged

Revert "Remove before_commit callback on test"#38
hamajyotan merged 1 commit intomainfrom
revert-37-remove-before-commit-callback

Conversation

@hamajyotan
Copy link
Copy Markdown
Owner

Reverts #37

After careful consideration, we decided to leave the tests as they were.

  • It would be useful to have them when we organize the ActiveRecord::Transactions module in the future.
  • ActiveRecord guarantees that tests for before_commit are supported.

@hamajyotan hamajyotan self-assigned this Oct 12, 2025
@hamajyotan hamajyotan merged commit 0cad40a into main Oct 12, 2025
15 checks passed
@hamajyotan hamajyotan deleted the revert-37-remove-before-commit-callback branch October 12, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant