Open
Conversation
If a state variable was not present, or had a bad/NaN value, an exception would be raised. In this case, the `_previous_data` attribute would not be updated, and the error would persist at future steps. This makes sure previous data is update AND make sure the input data is returned for other steps in the brokkr chain.
CAM-Gerlach
added
bug
CAM-Gerlach
requested changes
Oct 21, 2021
Member
There was a problem hiding this comment.
Actually, since the try block this finally block attaches to already has an except Exception that doesn't terminate execution (and no else block), in case of an error caught by it, execution just continues to these two lines anyway if any error occurs without this change. The only scenario this makes any difference in is if a KeyboardInterrupt or similar BaseException occurs during execution, in which case you want to terminate immediately and which is already caught and handled anyway by the custom signal/interrupt handler. So I'm not sure this PR really makes any difference?
Member
|
@pbitzer should we close this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a state variable was not present, or had a bad/NaN value, an exception would be raised. In this case, the
_previous_dataattribute would not be updated, and the error would persist at future steps. This makes sure previous data is update AND make sure the input data is returned for other steps in the brokkr chain.