Skip to content

Add literal types and values for logger levels #2056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 4.x
Choose a base branch
from
Open

Add literal types and values for logger levels #2056

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b207520
Add literal type for `logger.level` string values
mb-realpage Nov 23, 2024
f0443c1
Add log level constants to `logger`
mb-realpage Nov 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/handlebars/logger.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,4 +36,8 @@ let logger = {
}
};

logger.methodMap.forEach(function (levelName, levelNumber) {
logger[levelName.toUpperCase()] = levelNumber;
});

export default logger;
10 changes: 8 additions & 2 deletions types/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,14 +250,20 @@ declare namespace hbs {
type Utils = typeof Handlebars.Utils;
}

type LoggerLevel =
'debug'|
'info'|
'warn'|
'error';

interface Logger {
DEBUG: number;
INFO: number;
WARN: number;
ERROR: number;
level: number;
level: number | LoggerLevel;

methodMap: { [level: number]: string };
methodMap: { [level: number]: LoggerLevel };

log(level: number, obj: string): void;
}
Expand Down