Skip to content

Conversation

Laoujin
Copy link
Contributor

@Laoujin Laoujin commented Jul 14, 2025

…(import handlebars from 'handlebars') for use in modern app/typescript

Before creating a pull-request, please check https://github.com/handlebars-lang/handlebars.js/blob/master/CONTRIBUTING.md first.

Generally we like to see pull requests that

  • Please don't start pull requests for security issues. Instead, file a report at https://www.npmjs.com/advisories/report?package=handlebars
  • Maintain the existing code style
  • Are focused on a single change (i.e. avoid large refactoring or style adjustments in untouched code if not the primary goal of the pull request)
  • Have good commit messages
  • Have tests
  • Have the typings (types/index.d.ts) updated on every API change. If you need help, updating those, please mention that in the PR description.
  • Don't significantly decrease the current code coverage (see coverage/lcov-report/index.html)
  • Currently, the 4.x-branch contains the latest version. Please target that branch in the PR.

…(import handlebars from 'handlebars') for use in modern app/typescript
@Laoujin
Copy link
Contributor Author

Laoujin commented Jul 14, 2025

I didn't get any of these (#1528) to work for me (using TypeScript and "type": "module")
Instead of updating the output manually, I created this PR 😀

If you'd like, I can also update /docs

@Laoujin
Copy link
Contributor Author

Laoujin commented Jul 14, 2025

I just went ahead and added it to the docs:
https://github.com/handlebars-lang/docs/pull/165/files

If you want it differently, just let me know :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants