Deploy to staging: develop #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added eslint-plugin-jasmine and eslint-plugin-jest * Fix eslint-plugin-jest errors * Remove duplicated tests
…-microsoft-excel guide (#1567) * Docs: summerize the Excel function coverage in the compatibility-with-microsoft-excel guide * Update docs/guide/compatibility-with-microsoft-excel.md Co-authored-by: Marcin Warpechowski <[email protected]> --------- Co-authored-by: Marcin Warpechowski <[email protected]>
…of the formula cell is not computed` error (#1569) * Add unit tests reproducing the bug * Fix the error * Improve test utils log message for columnIndexToSheet function * Add jsdoc comments to Operations.ts file
…nd renaming sheets (#1570) * Add unit test that reproduce the issue * Add changelog entry * Don't omit end address in RemoveSheetTransformer * Add npm script for npm audit * Add more unit tests * Fix linter in tests * Make SheetMapping store reserved sheet names * Adjust graphComparator * Adjust evaluator to handle not-added sheets correctly * Adjust tests in compute-hash-from-tokens.spec.ts * Adjust tests in parser.spec.ts * Fix numeric aggregation plugin * Make addSheet operation update the relevant dependency * Adjust tests in named-expressions.spec.ts * Adjust tests in mitting-events.spec.ts * Add complex range test scenarios * Remove vertices only if they are not referenced by existing sheets * Adjust tests in removing-sheet.spec.ts * Refactor: create SheetReferenceRegistrar * Remove sheet from AddressMapping if nothing else depends on it * Remove unused functions * Remove unused constructor parameters * Adjust range vertices after rename sheet * Update sheet strategy in AddressMapping if placeholder exists * Improve docs in SheetMapping * Refactor NumericAggregationPlugin * Rename function to more descriptive name * Refactor addressRepresentationConverters * Refactor Graph.ts * Refactor SheetReferenceRegistrar.ts * Refactor RangeMapping * Remove RemoveSheetTransformem which is not needed anymore * Rename FormulaCellVertex -> ScalarFormulaVertex and ArrayVertex -> ArrayFormulaVertex * Refactor DependencyGraph * Refactor Operations * Refactor DependencyGraph.removeSheet * Make sure renameSheet handles dependency graph correctly * Refactor DependencyGraph.mergeSheets() * Refactor DependencyGraph * Hande undoAddSheet and redoAddSheet * Hande undoRemoveSheet and redoRemoveSheet * Add tests for undo/redo renameSheet() * Handle undo for renameSheet() * Apply suggestions from agent review * Configure eslint to allow null assertions in test files * Remove placeholder sheets when not needed enymore * Apply suggestions after agentic code review of the test files * Test the cleanup of placeholder sheets
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -1,29 +1,29 @@ | |||
| import {ExportedCellChange, HyperFormula, NoSheetWithIdError} from '../../../src' | |||
| import {ExportedCellChange, HyperFormula, NoSheetWithIdError, CellValueType} from '../../../src' | |||
Check notice
Code scanning / CodeQL
Unused variable, import, function or class Note test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.