Skip to content

Conversation

@sequba
Copy link
Contributor

@sequba sequba commented Jan 16, 2025

Context

The implementation of the OFFSET function in HyperFormula has some limitations. The first argument must be a reference to a single cell. Ranges are not allowed.

How did you test your changes?

local docs build

Types of changes

  • Breaking change (a fix or a feature because of which an existing functionality doesn't work as expected anymore)
  • New feature or improvement (a non-breaking change that adds functionality)
  • Bug fix (a non-breaking change that fixes an issue)
  • Additional language file, or a change to an existing language file (translations)
  • Change to the documentation

Related issues:

Fixes #1477

Checklist:

  • I have reviewed the guidelines about Contributing to HyperFormula and I confirm that my code follows the code style of this project.
  • I have signed the Contributor License Agreement.
  • My change is compliant with the OpenDocument standard.
  • My change is compatible with Microsoft Excel.
  • My change is compatible with Google Sheets.
  • I described my changes in the CHANGELOG.md file.
  • My changes require a documentation update.
  • My changes require a migration guide.

@sequba sequba self-assigned this Jan 16, 2025
@github-actions
Copy link

github-actions bot commented Jan 16, 2025

Performance comparison of head (25eeab0) vs base (f392eae)

                                     testName |   base |   head | change
------------------------------------------------------------------------
                                      Sheet A | 506.76 | 503.87 | -0.57%
                                      Sheet B | 161.36 |    163 | +1.02%
                                      Sheet T |  142.8 | 143.94 | +0.80%
                                Column ranges | 508.64 | 510.05 | +0.28%
Sheet A:  change value, add/remove row/column |  13.63 |  13.93 | +2.20%
 Sheet B: change value, add/remove row/column | 123.12 |  121.5 | -1.32%
                   Column ranges - add column | 152.79 | 150.54 | -1.47%
                Column ranges - without batch | 428.82 | 438.38 | +2.23%
                        Column ranges - batch | 110.98 | 110.91 | -0.06%

@sequba sequba marked this pull request as ready for review January 21, 2025 12:17
@sequba sequba merged commit ed575db into develop Jan 21, 2025
24 checks passed
@sequba sequba deleted the feature/issue-1477 branch January 21, 2025 12:18
@codecov
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.22%. Comparing base (f392eae) to head (25eeab0).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1488   +/-   ##
========================================
  Coverage    97.22%   97.22%           
========================================
  Files          169      169           
  Lines        14523    14523           
  Branches      3080     3080           
========================================
  Hits         14120    14120           
  Misses         403      403           

mountEvarus pushed a commit to Stellar-Fusion/hyperformula that referenced this pull request Sep 16, 2025
…nces guide (handsontable#1488)

* Describe the limitation of the OFFSET function in the runtime differences guide

* Improve formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants