[1팀 박용호] Chapter 2-3. 관심사 분리와 폴더구조#55
Open
ParkYongHo1 wants to merge 12 commits intohanghae-plus:mainfrom
Open
[1팀 박용호] Chapter 2-3. 관심사 분리와 폴더구조#55ParkYongHo1 wants to merge 12 commits intohanghae-plus:mainfrom
ParkYongHo1 wants to merge 12 commits intohanghae-plus:mainfrom
Conversation
ywkim95
reviewed
May 15, 2025
ywkim95
left a comment
ywkim95
left a comment
There was a problem hiding this comment.
용호님 고생 많으셨어요!
코드가 너무 깔끔하게 잘 작성되어 있어서 파고들 틈이 거의 없네요 ㅎㅎ
용호님 코드를 보니 제가 아직 부족하다는게 많이 느껴지네요!
과제 고생하셨습니다~~!
There was a problem hiding this comment.
다른 파일은 전부 1개의 로직만 존재하도록 분리하셨는데 해당 파일은 왜 로직이 2개를 선언했는지 궁금하네요!
Comment on lines
+4
to
+7
| export const postKeys = createQueryKeys("posts", { | ||
| fetch: (props: SearchParams & { searchQuery: string; tag: string }) => [props], | ||
| tags: () => ["tags"], | ||
| }) |
| import { deleteComment } from "@/entities/comment/api" | ||
|
|
||
| export const useDeleteCommentMutation = () => { | ||
| const queryClient = useQueryClient() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
과제 체크포인트
배포링크 https://parkyongho1.github.io/front_5th_chapter2-3/
기본과제
목표 : 전역상태관리를 이용한 적절한 분리와 계층에 대한 이해를 통한 FSD 폴더 구조 적용하기
체크포인트
심화과제
목표: 서버상태관리 도구인 TanstackQuery를 이용하여 비동기코드를 선언적인 함수형 프로그래밍으로 작성하기
체크포인트
과제 셀프회고
과제에서 좋았던 부분
하지만 처음 써보는것들이라 AI에 너무 의존을 했던 한주였던것 같습니다... 과제 제출에 급급하여 막 쓴게 아쉬웠습니다,,