Updated to use remote Browser Window and ipcRenderer#18
Open
ahallicks wants to merge 1 commit intohankbao:masterfrom
Open
Updated to use remote Browser Window and ipcRenderer#18ahallicks wants to merge 1 commit intohankbao:masterfrom
ahallicks wants to merge 1 commit intohankbao:masterfrom
Conversation
sireaev
approved these changes
Dec 8, 2018
konrad-ch
approved these changes
Jan 17, 2019
djsavvy
approved these changes
Jul 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When used from the renderer process I get all kinds of errors about Browser Window not being defined. This seems to fix it all.