Backend: Move ErrorManager Consts to Repo#4514
Draft
DavidArthurCole wants to merge 4 commits intohannibal002:betafrom
Draft
Backend: Move ErrorManager Consts to Repo#4514DavidArthurCole wants to merge 4 commits intohannibal002:betafrom
DavidArthurCole wants to merge 4 commits intohannibal002:betafrom
Conversation
github-actions
bot
added
Waiting on Dependency PR
github-actions
bot
removed
Waiting on Dependency PR
github-actions
bot
added
the
Backend
hannibal002
requested changes
Feb 25, 2026
Owner
hannibal002
left a comment
hannibal002
left a comment
There was a problem hiding this comment.
the values in the repo are correct
|
|
||
| import com.google.gson.annotations.Expose | ||
|
|
||
| data class ErrorManagerJson( |
Owner
There was a problem hiding this comment.
please do not use camel case names in the json. e.g. in the json, use break_after, then use @SerializedName to map this to the kotlin variable breakAfter
| fun onRepoReload(event: RepositoryReloadEvent) { | ||
| val repoData = event.getConstant<ErrorManagerJson>("ErrorManager") | ||
| breakAfter = repoData.breakAfter | ||
| replace = repoData.replacements |
Owner
There was a problem hiding this comment.
please use consistent variable names, for replace vs replacements and replace entirely vs entire replacements
| "at net.minecraft.client.main.Main.main", | ||
| "at.hannibal2.skyhanni.api.event.EventListeners.createZeroParameterConsumer", | ||
| "at.hannibal2.skyhanni.api.event.EventListeners.createSingleParameterConsumer", | ||
| "at.hannibal2.skyhanni.api.event.SkyHanniEvent.post" |
Owner
There was a problem hiding this comment.
please add the trailing comma
Contributor
Author
Yes, this branch is massively outdated, and needs updating for Fabric, anyways. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependencies
What
Moves the ErrorManager constants to the repo so we can whittle down stacks ad-hoc without changing versions.
I left the 'old' values in place in the default vars, as there are definitely code paths that would lead to ErrorManager being called before repo load.
I also added
at.hannibal2.skyhanni.api.event.SkyHanniEvent.postas one of thebreakAftervalues, as it's always the trace down to the packet level after that in the stack.Changelog Technical Details