Improvement + Fix: Level 100 Pet Price Support* #5137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/main/java/at/hannibal2/skyhanni/features/misc/items/EstimatedItemValueCalculator.kt
Outdated
Show resolved
Hide resolved
NopoTheGamer
requested changes
Jan 22, 2026
github-actions
bot
added
the
Wrong Title/Changelog
|
I have detected some issues with your pull request: Body issues: Please fix these issues. For the correct format, refer to the pull request template. |
github-actions
bot
removed
the
Wrong Title/Changelog
1 Detekt Failure
|
1 Detekt Failure
|
NopoTheGamer
requested changes
Jan 27, 2026
| val maxLevel = getMaxLevel(internalName) | ||
|
|
||
| if (this.getPetLevel() == maxLevel) { | ||
| internalName = "${internalName.asString()}+${this.getPetLevel()}".toInternalName() |
Collaborator
There was a problem hiding this comment.
the api seems to only support level 200 gregs
|
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
github-actions
bot
added
the
Merge Conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds Level 100 Pet Support to Estimated Item Value Calculator, Chest Value Display & Auction House Copy Underbid Price
Also fixed auto copy underbid copying more than once
Changelog Improvements
Estimated Item Value now accurately calculates level 100 pets. - Fazfoxy
Auto Copy Underbid Now Copies max level LBin. - Fazfoxy
Changelog Fixes