Re: Feature: Add missing Tab Widget displays #5183
Conversation
- Fix POWDERS reference (TabWidget.POWDER) - Rename SHEN_RIFT to RIFT_SHEN for consistency - Add missing widget displays: RIFT_INFO, JACOB_CONTEST, ELECTION, NORTH_STARS, EVENT, ESSENCE, FORGE, DUNGEON_STATS, PARTY, TRAPPER, CRYSTAL, REPUTATION, FACTION_QUESTS, TROPHY_FISH, COMPOSTER, COPPER, VISITORS, SALTS
…ing bad. Removed it now
There was a problem hiding this comment.
Pull request overview
This PR adds 18 missing tab widget display mappings that were previously unavailable in the TabWidgetDisplay enum. These widgets already existed in the underlying TabWidget enum but were not exposed to users through the display configuration.
Changes:
- Added 18 new TabWidgetDisplay enum entries: RIFT_INFO, JACOB_CONTEST, POWDERS, ELECTION, NORTH_STARS, EVENT, ESSENCE, FORGE, PARTY, TRAPPER, CRYSTAL, REPUTATION, FACTION_QUESTS, TROPHY_FISH, COMPOSTER, COPPER, VISITORS, and SALTS
- Each new entry properly maps to its corresponding TabWidget enum value
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
github-actions
bot
added
the
Wrong Title/Changelog
And immediately requests copilot review |
There was a problem hiding this comment.
This doesn't address the third concern that nopo mentioned previously as some people have much shorter screens or play with a higher gui scale plus a lot of these widgets were not added to the display because skyhanni already has specific features relating to them or because other mods have features that are better than the widget
|
I didnt request copilot review, that is automatic i think (Upon checking it was automatic, i disabled it now) Also how about adding just a few useful ones then? Like powders, reputation, trapper |
2 participants
Dependencies
Demo & Images (Almost all Islands, with all the widgets enabled)
Dragging.Widgets.mp4
Changes:
Changelog New Features