Fix: MobHighlight #5185
Open
Fix: MobHighlight #5185
+57
−114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 Detekt Failure
|
hannibal002
requested changes
Feb 9, 2026
Owner
hannibal002
left a comment
hannibal002
left a comment
There was a problem hiding this comment.
the cleanup and migration to mob detection looks good!
small suggetions, and i assume you have tested that the code works well with death/despawn/world switch?
src/main/java/at/hannibal2/skyhanni/features/combat/mobs/MobHighlight.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/combat/mobs/MobHighlight.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/combat/mobs/MobHighlight.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/combat/mobs/MobHighlight.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Revival of #2114
Refactors the MobHighlight class to (mostly) use mob detection. For highlighting zealots the old EntityMaxHealthUpdateEvent is used instead, as mob detection currently does not work with mobs that are far away.
Corrupted highlight still doesn't work the best since it should probably use nametags instead, but somebody else can do that.
Changelog Fixes
Changelog Technical Details