Nopo I Neeeed Thissss (Vanquisher Waypoint Share Feature and Config file) #5197
+330
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Wrong Title/Changelog
|
I have detected some issues with your pull request: Body issues: Please fix these issues. For the correct format, refer to the pull request template. |
NopoTheGamer
requested changes
Feb 2, 2026
Collaborator
NopoTheGamer
left a comment
NopoTheGamer
left a comment
There was a problem hiding this comment.
the whole file needs to be formatted (do ctrl alt l in intellij)
Comment on lines
11
to
30
| //Share vanquisher spawns | ||
| @Expose | ||
| @ConfigOption(name = "Enabled", desc = "Share your Vanquisher spawns and receive other Vanquisher spawns via Party Chat") | ||
| @ConfigEditorBoolean | ||
| @FeatureToggle | ||
| var enabled: Boolean = true | ||
|
|
||
| //Instant share w/o keybind | ||
| @Expose | ||
| @ConfigOption(name = "Instant Share", desc = "Instantly share your Vanquisher spawns via Party Chat") | ||
| @ConfigEditorBoolean | ||
| var instantShare: Boolean = true | ||
|
|
||
| //Manually share with keybind | ||
| @Expose | ||
| @ConfigOption(name = "Keybind Share", desc = "Manually share your Vanquisher spawns with a keybind") | ||
| @ConfigEditorKeybind(defaultKey = GLFW.GLFW_KEY_Y) | ||
| var keybindSharing: Int = GLFW.GLFW_KEY_Y | ||
|
|
||
| //Read global chat to recognize non-party members' Vanquisher spawns |
Collaborator
There was a problem hiding this comment.
remove the chat gpt comments
Comment on lines
44
to
57
| @Suppress("MaxLineLength") | ||
| private val vanquisherSharedPattern by patternGroup.list( | ||
| "coords", | ||
| "(?<party>§9Party §8> )?(?<playerName>.+)§f: (?<x>[^ ]+): (?<y>[^ ]+): (?<z>[^ ]+): | Vanquisher" | ||
| ) | ||
|
|
||
| private val vanquisherDiedPattern by patternGroup.pattern( | ||
| "died", | ||
| "(?<party>§9Party §8> )?(?<playerName>.*)§f: §rVanquisher dead!", | ||
| ) | ||
| private val vanquisherSpawnedPattern by patternGroup.pattern( | ||
| "spawned", | ||
| ".*§aA §r§cVanquisher §r§ais spawning nearby!" | ||
| ) |
| } | ||
|
|
||
| @HandleEvent | ||
| fun onRawEntityJoin(event: EntityEnterWorldEvent<Entity>) { |
Collaborator
There was a problem hiding this comment.
you can change Entity to the one you need (armour stand im guessing?)
Comment on lines
216
to
217
| if (entity !is LivingEntity) return | ||
| if (entity is RemotePlayer) return |
Collaborator
There was a problem hiding this comment.
and then you can remove this
| @HandleEvent(onlyOnIsland = IslandType.CRIMSON_ISLE, receiveCancelled = true) | ||
| fun readChat(event: SkyHanniChatEvent.Allow) { | ||
| if(!isEnabled()) return | ||
| val message = event.message |
Collaborator
There was a problem hiding this comment.
use cleanMessage instead
53 Detekt FailuresRules flagged (7): Rule violations
|
57 Detekt FailuresRules flagged (7): Rule violations
|
58 Detekt FailuresRules flagged (7): Rule violations
|
58 Detekt FailuresRules flagged (7): Rule violations
|
31 Detekt FailuresRules flagged (8): Rule violations
|
12 Detekt FailuresRules flagged (3): Rule violations
|
jani270
requested changes
Feb 4, 2026
|
|
||
| class VanquisherWaypointShareConfig { | ||
| @Expose | ||
| @ConfigOption(name = "Enabled", desc = "Share your Vanquisher spawns and receive other Vanquisher spawns via Party Chat") |
Collaborator
There was a problem hiding this comment.
Suggested change
| @ConfigOption(name = "Enabled", desc = "Share your Vanquisher spawns and receive other Vanquisher spawns via Party Chat") | |
| @ConfigOption(name = "Enabled", desc = "Share your Vanquisher spawns and receive other Vanquisher spawns via Party Chat.") |
| var enabled: Boolean = true | ||
|
|
||
| @Expose | ||
| @ConfigOption(name = "Instant Share", desc = "Instantly share your Vanquisher spawns via Party Chat") |
Collaborator
There was a problem hiding this comment.
Suggested change
| @ConfigOption(name = "Instant Share", desc = "Instantly share your Vanquisher spawns via Party Chat") | |
| @ConfigOption(name = "Instant Share", desc = "Instantly share your Vanquisher spawns via Party Chat.") |
| var instantShare: Boolean = true | ||
|
|
||
| @Expose | ||
| @ConfigOption(name = "Keybind Share", desc = "Manually share your Vanquisher spawns with a keybind") |
Collaborator
There was a problem hiding this comment.
Suggested change
| @ConfigOption(name = "Keybind Share", desc = "Manually share your Vanquisher spawns with a keybind") | |
| @ConfigOption(name = "Keybind Share", desc = "Manually share your Vanquisher spawns with a keybind.") |
| var keybindSharing: Int = GLFW.GLFW_KEY_Y | ||
|
|
||
| @Expose | ||
| @ConfigOption(name = "Read Global Chat", desc = "Register Vanquisher spawns from All Chat and Party Chat") |
Collaborator
There was a problem hiding this comment.
Suggested change
| @ConfigOption(name = "Read Global Chat", desc = "Register Vanquisher spawns from All Chat and Party Chat") | |
| @ConfigOption(name = "Read Global Chat", desc = "Register Vanquisher spawns from All Chat and Party Chat.") |
| ) | ||
|
|
||
| /** | ||
| * REGEX-TEST: .*A Vanquisher is spawning nearby! |
Collaborator
There was a problem hiding this comment.
I dont think the message on hypixel has a .* infront
NopoTheGamer
requested changes
Feb 5, 2026
|
|
||
|
|
||
| /** | ||
| * REGEX-TEST: §9Party §8> User Name§f: x: 2.3, y: 4.5, z: -6.7 | Vanquisher |
Collaborator
There was a problem hiding this comment.
regex tests are meant to test real messages, not messages made to fit the regex
|
|
||
| TitleManager.sendTitle( | ||
| "§5§lVanquisher Spawned!", | ||
| "§r§7You found one nearby!", |
Collaborator
There was a problem hiding this comment.
the reset does nothing
| for (waypoint in waypoints.values) { | ||
| if (waypoint.spawnTime.passedSince() > 30.seconds) continue | ||
|
|
||
| val beaconColor = java.awt.Color(160, 37, 191) |
Collaborator
There was a problem hiding this comment.
this should just be Color(..)
| val y = location.y.toInt() | ||
| val z = location.z.toInt() | ||
|
|
||
| HypixelCommands.partyChat("x: $x, y: $y, z: $z | Vanquisher") |
Collaborator
There was a problem hiding this comment.
does this check if you are a party
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@NopoTheGamer pls help