Skip to content

Conversation

@NopoTheGamer
Copy link
Collaborator

What

cus i felt likt it
still has issues not yet fixed

Changelog Fixes

  • Fixed something in Player Name Formatter. - nopo

Changelog Technical Details

  • redid the code for player name formatter. - nopo

@github-actions github-actions bot added Backend A backend pull request that will be merged soon Wrong Title/Changelog There is an error in the title or changelog labels Feb 5, 2026
@github-actions
Copy link

github-actions bot commented Feb 5, 2026

I have detected some issues with your pull request:

Body issues:
Change should start with a capital letter in text: redid the code for player name formatter.

Title issues:
PR title must include category 'Fix' if there are any fixes in the PR

Please fix these issues. For the correct format, refer to the pull request template.

@github-actions github-actions bot added the Detekt Has detekt problem label Feb 5, 2026
@github-actions
Copy link

github-actions bot commented Feb 5, 2026

10 Detekt Failures

Rules flagged (4): Indentation, Wrapping, UnsafeCallOnNullableType, MaxLineLength
Files flagged (2): PlayerNameFormatter.kt, PlayerChatManager.kt

Rule violations

@hannibal002
Copy link
Owner

Moving to draft.

There's commented-out code that needs to be either properly ported or removed, throw Error() should use ErrorManager, and the PR description needs to explain properly why we change this and mention the known remaining issues properly.

@hannibal002 hannibal002 marked this pull request as draft February 9, 2026 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backend A backend pull request that will be merged soon Detekt Has detekt problem Wrong Title/Changelog There is an error in the title or changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants