-
-
Notifications
You must be signed in to change notification settings - Fork 299
Feature: Fire Freeze Additions #5224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: beta
Are you sure you want to change the base?
Conversation
src/main/java/at/hannibal2/skyhanni/features/combat/FireFreezeFeatures.kt
Outdated
Show resolved
Hide resolved
|
I have detected some issues with your pull request: Body issues: Please fix these issues. For the correct format, refer to the pull request template. |
2 Detekt FailuresRules flagged (2):
|
hannibal002
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall the feature looks cool and well coded!
src/main/java/at/hannibal2/skyhanni/config/features/combat/CombatConfig.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/config/features/combat/FireFreezeConfig.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/combat/FireFreezeFeatures.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/combat/FireFreezeFeatures.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/config/features/combat/FireFreezeConfig.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/config/features/combat/FireFreezeConfig.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/combat/FireFreezeFeatures.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/combat/FireFreezeFeatures.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/combat/FireFreezeFeatures.kt
Outdated
Show resolved
Hide resolved
10 Detekt FailuresRules flagged (5): Rule violations
|
Dependencies
What
This is Another Empa Feature Port thing, code might be fucked from taking from 1.8 manually
Images
Changelog New Features