Feature: Fire Freeze Additions

[Fazfoxy]

Dependencies

• Fire Freeze Skulls SkyHanni-REPO#612 (review)

What

This is Another Empa Feature Port thing, code might be fucked from taking from 1.8 manually

Images

Changelog New Features

• Added Fire Freeze Features. - Empa & Fazfoxy
  • Timer/Box on Mobs for Freeze Timer.
  • Timer until Freeze Activation.
  • Particle Replacer with Circular Line.

[github-actions]

I have detected some issues with your pull request:

Body issues:
Change should end with a full stop in text: Fire Freeze Features

Please fix these issues. For the correct format, refer to the pull request template.

[github-actions]

2 Detekt Failures

Rules flagged (2): MaxLineLength, UnusedPrivateProperty
Files flagged (2): WorldRenderUtils.kt, FireFreezeFeatures.kt

• WorldRenderUtils.kt#L323 MaxLineLength: Line detected, which is longer than the defined maximum line length in the code style.
• FireFreezeFeatures.kt#L84 UnusedPrivateProperty: Private property chargeUpDuration is unused.

[hannibal002]

Overall the feature looks cool and well coded!

[github-actions]

10 Detekt Failures

Rules flagged (5): AvoidBritishSpelling, NoUnusedImports, Wrapping, SpacingAroundComma, MaxLineLength
Files flagged (3): FireFreezeConfig.kt, ItemAbilityConfig.kt, FireFreezeFeatures.kt

Rule violations

• FireFreezeConfig.kt#L39 AvoidBritishSpelling: Avoid using the word 'colour' in code, 'color' is preferred instead.
• FireFreezeConfig.kt#L39 AvoidBritishSpelling: Avoid using the word 'colour' in code, 'color' is preferred instead.
• ItemAbilityConfig.kt#L4 NoUnusedImports: Unnecessary import
• FireFreezeConfig.kt#L8 NoUnusedImports: Unused import
• FireFreezeConfig.kt#L26 Wrapping: Missing newline after ","
• FireFreezeConfig.kt#L26 Wrapping: Missing newline after "("
• FireFreezeConfig.kt#L27 Wrapping: Missing newline before ")"
• FireFreezeFeatures.kt#L65 SpacingAroundComma: Missing spacing after ","
• FireFreezeConfig.kt#L33 MaxLineLength: Line detected, which is longer than the defined maximum line length in the code style.
• FireFreezeFeatures.kt#L70 MaxLineLength: Line detected, which is longer than the defined maximum line length in the code style.

[hannibal002]

logic looks fire.

only typos.

btw, please add the prefix "Add ..." to the chagnelog line for new features

[hannibal002]

LGTM