Improvement: Different color for non-maxed Ultimate Enchants #5232
+37
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bloxigus
reviewed
Feb 11, 2026
src/main/java/at/hannibal2/skyhanni/features/misc/items/enchants/Enchant.kt
Outdated
Show resolved
Hide resolved
github-actions
bot
added
the
Wrong Title/Changelog
|
I have detected some issues with your pull request: Body issues: Please fix these issues. For the correct format, refer to the pull request template. |
NopoTheGamer
requested changes
Feb 11, 2026
src/main/java/at/hannibal2/skyhanni/config/features/inventory/EnchantParsingConfig.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/misc/items/enchants/Enchant.kt
Outdated
Show resolved
Hide resolved
NopoTheGamer
requested changes
Feb 11, 2026
src/main/java/at/hannibal2/skyhanni/features/misc/items/enchants/Enchant.kt
Outdated
Show resolved
Hide resolved
lunaynx
suggested changes
Feb 11, 2026
src/main/java/at/hannibal2/skyhanni/config/features/inventory/EnchantParsingConfig.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/misc/items/enchants/Enchant.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/misc/items/enchants/Enchant.kt
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/misc/items/enchants/Enchant.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/misc/items/enchants/Enchant.kt
Outdated
Show resolved
Hide resolved
…EnchantParsingConfig.kt Co-authored-by: Luna <[email protected]>
…ts/Enchant.kt Co-authored-by: Luna <[email protected]>
…ts/Enchant.kt Co-authored-by: Luna <[email protected]>
…ts/Enchant.kt Co-authored-by: Luna <[email protected]>
github-actions
bot
added
Fails Multi-Version
lunaynx
suggested changes
Feb 11, 2026
src/main/java/at/hannibal2/skyhanni/features/misc/items/enchants/Enchant.kt
Outdated
Show resolved
Hide resolved
1 Detekt Failure
|
2 Detekt Failures
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds an option to render non-maxed Ultimate Enchants in a different color than maxed ones.
Details
Screenshots
Dependencies
None