Skip to content

Fix: Add Overclocker to Compact Jacob Claim & Missed Messages#5235

Open
DavidArthurCole wants to merge 5 commits intohannibal002:betafrom
DavidArthurCole:fix/contest-rewards
Open

Fix: Add Overclocker to Compact Jacob Claim & Missed Messages#5235
DavidArthurCole wants to merge 5 commits intohannibal002:betafrom
DavidArthurCole:fix/contest-rewards

Conversation

@DavidArthurCole
Copy link
Contributor

@DavidArthurCole DavidArthurCole commented Feb 11, 2026

What

https://discord.com/channels/997079228510117908/1094190239532208228/1470827076670980116
Overclockers were not being detected/blocked/reported. (First image)

When claiming rewards from a singular contest, we'd miss one of the lines.
Regex for tickets was also malformed, so in the absence of x ..., the line would be ignored.
(Both of these, second image)

Images

Overclocker
image

Singular claim + ticket missing
jacob

Changelog Fixes

  • Fixed Overclockers not being detected when claiming Jacob contest rewards. - Daveed
  • Fixed Compact Jacob Claim missing some lines when claiming singular contests. - Daveed
  • Fixed Compact Jacob Claim missing singular carnival/jacob tickets. - Daveed

@github-actions github-actions bot added the Detekt Has detekt problem label Feb 11, 2026
@github-actions
Copy link

2 Detekt Failures

Rules flagged (2): RepoPatternRegexTestFailed, StringTemplate

@github-actions github-actions bot removed the Detekt Has detekt problem label Feb 11, 2026
Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a clean impl. just two small things

@NopoTheGamer
Copy link
Collaborator

i personally feel like its weird if it doesnt say the proper name "Overclocker 3000"

@DavidArthurCole
Copy link
Contributor Author

i personally feel like its weird if it doesnt say the proper name "Overclocker 3000"

image

We don't exactly have a lot of space. Things get shortened drastically, and this (not including 3000) would not be the most heinous exclusionary code in this file.

It's the only item or concept in skyblock that shares the name. I don't understand why it'd be weird to shorthand it to save some room in what is already a crowded message.

@DavidArthurCole DavidArthurCole changed the title Fix: Add Overclocker to Compact Jacob Claim Fix: Add Overclocker to Compact Jacob Claim & Missed Messages Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments