Fix: Add Overclocker to Compact Jacob Claim & Missed Messages#5235
Open
DavidArthurCole wants to merge 5 commits intohannibal002:betafrom
Open
Fix: Add Overclocker to Compact Jacob Claim & Missed Messages#5235DavidArthurCole wants to merge 5 commits intohannibal002:betafrom
DavidArthurCole wants to merge 5 commits intohannibal002:betafrom
Conversation
2 Detekt FailuresRules flagged (2):
|
hannibal002
requested changes
Feb 12, 2026
Owner
hannibal002
left a comment
There was a problem hiding this comment.
looks like a clean impl. just two small things
src/main/java/at/hannibal2/skyhanni/features/chat/CompactJacobClaim.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/chat/CompactJacobClaim.kt
Outdated
Show resolved
Hide resolved
Collaborator
|
i personally feel like its weird if it doesnt say the proper name "Overclocker 3000" |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What
https://discord.com/channels/997079228510117908/1094190239532208228/1470827076670980116
Overclockers were not being detected/blocked/reported. (First image)
When claiming rewards from a singular contest, we'd miss one of the lines.
Regex for tickets was also malformed, so in the absence of
x ..., the line would be ignored.(Both of these, second image)
Images
Overclocker

Singular claim + ticket missing

Changelog Fixes