Skip to content

Backend: isCurrent -> isInIsland#5476

Open
hannibal002 wants to merge 2 commits intobetafrom
backend/new-island
Open

Backend: isCurrent -> isInIsland#5476
hannibal002 wants to merge 2 commits intobetafrom
backend/new-island

Conversation

@hannibal002
Copy link
Copy Markdown
Owner

@hannibal002 hannibal002 commented Mar 25, 2026

first merge:

isCurrent -> isInIsland

ignore_from_changelog

@github-actions github-actions bot added Backend A backend pull request that will be merged soon Detekt Has detekt problem labels Mar 25, 2026
@github-actions
Copy link
Copy Markdown

1 Detekt Failure

  • StorageApi.kt#L100 IsInIslandEarlyReturn: This early return should be replaced with onlyOnIsland = IslandType in the @HandleEvent annotation

@hannibal002
Copy link
Copy Markdown
Owner Author

detekt is lying here

image

@github-actions github-actions bot removed the Detekt Has detekt problem label Mar 25, 2026
@DavidArthurCole
Copy link
Copy Markdown
Contributor

Please merge #5419 first - it supersedes a lot these instances.

@hannibal002 hannibal002 added the Waiting on Dependency PR waiting for a dependency pr to be merged label Mar 28, 2026
@github-actions
Copy link
Copy Markdown

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Mar 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backend A backend pull request that will be merged soon Merge Conflicts There are open merge conflicts with the beta branch. Waiting on Dependency PR waiting for a dependency pr to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants